[v3] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424

[PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424

Posted by Kathiravan Thirumoorthy 8 months, 1 week ago

With the current settings, compliance tests are failing, especially eye
diagram (Host High-speed Signal Quality) tests. Reuse the IPQ6018
settings, as mentioned in the Hardware Design Document.

Merge Strategy:
--------------
Both the patch in the series should be merged together to avoid breaking
the USB feature.

--
Changes in v3:
	- s/complaince/compliance (Mukesh)
	- s/design team/Hardware Design Document (Mukesh)
	- Link to v2: https://lore.kernel.org/r/20250414-revert_hs_phy_settings-v2-0-25086e20a3a3@oss.qualcomm.com

Changes in V2
	- Splitted the patch into 2 patches, first revert the commit and
	  then reuse the IPQ6018 data (Vinod K)
	- Dropped the R-b tag from Dmitry
	- Link to v1 -
	  https://lore.kernel.org/linux-arm-msm/20250407-revert_hs_phy_settings-v1-1-ec94e316ea19@oss.qualcomm.com/

---
Kathiravan Thirumoorthy (2):
      Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
      phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424

 drivers/phy/qualcomm/phy-qcom-qusb2.c | 27 +--------------------------
 1 file changed, 1 insertion(+), 26 deletions(-)
---
base-commit: b425262c07a6a643ebeed91046e161e20b944164
change-id: 20250414-revert_hs_phy_settings-47643d2c75ba

Best regards,
-- 
Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>

Re: [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424

Posted by Vinod Koul 7 months, 1 week ago

On Tue, 15 Apr 2025 09:52:49 +0530, Kathiravan Thirumoorthy wrote:
> With the current settings, compliance tests are failing, especially eye
> diagram (Host High-speed Signal Quality) tests. Reuse the IPQ6018
> settings, as mentioned in the Hardware Design Document.
> 
> Merge Strategy:
> --------------
> Both the patch in the series should be merged together to avoid breaking
> the USB feature.
> 
> [...]

Applied, thanks!

[1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
      commit: 8a040e13afd94a1f91acaf8e0505769d4f7f5af4
[2/2] phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424
      commit: 25c36b54eafc98b3ef004e2037cea1328d9b8bc5

Best regards,
-- 
~Vinod

Re: [PATCH v3 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424

Posted by Kathiravan Thirumoorthy 7 months, 3 weeks ago

On 4/15/2025 9:52 AM, Kathiravan Thirumoorthy wrote:
> With the current settings, compliance tests are failing, especially eye
> diagram (Host High-speed Signal Quality) tests. Reuse the IPQ6018
> settings, as mentioned in the Hardware Design Document.
>
> Merge Strategy:
> --------------
> Both the patch in the series should be merged together to avoid breaking
> the USB feature.


Gentle Reminder...


>
> --
> Changes in v3:
> 	- s/complaince/compliance (Mukesh)
> 	- s/design team/Hardware Design Document (Mukesh)
> 	- Link to v2: https://lore.kernel.org/r/20250414-revert_hs_phy_settings-v2-0-25086e20a3a3@oss.qualcomm.com
>
> Changes in V2
> 	- Splitted the patch into 2 patches, first revert the commit and
> 	  then reuse the IPQ6018 data (Vinod K)
> 	- Dropped the R-b tag from Dmitry
> 	- Link to v1 -
> 	  https://lore.kernel.org/linux-arm-msm/20250407-revert_hs_phy_settings-v1-1-ec94e316ea19@oss.qualcomm.com/
>
> ---
> Kathiravan Thirumoorthy (2):
>        Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
>        phy: qcom-qusb2: reuse the IPQ6018 settings for IPQ5424
>
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 27 +--------------------------
>   1 file changed, 1 insertion(+), 26 deletions(-)
> ---
> base-commit: b425262c07a6a643ebeed91046e161e20b944164
> change-id: 20250414-revert_hs_phy_settings-47643d2c75ba
>
> Best regards,