[PATCH 1/2] kunit: qemu_configs: sparc: Explicitly enable CONFIG_SPARC32=y

Thomas Weißschuh posted 2 patches 8 months ago
[PATCH 1/2] kunit: qemu_configs: sparc: Explicitly enable CONFIG_SPARC32=y
Posted by Thomas Weißschuh 8 months ago
The configuration generated by kunit ends up with a 32bit configuration.
A new kunit configuration for 64bit is to be added.
To make the difference clearer spell out the variant in the kunit
reference config.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 tools/testing/kunit/qemu_configs/sparc.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/kunit/qemu_configs/sparc.py b/tools/testing/kunit/qemu_configs/sparc.py
index 256d9573b44646533d1a6f768976628adc87921e..3131dd299a6e34f027402e99e34d85ddcaa359b7 100644
--- a/tools/testing/kunit/qemu_configs/sparc.py
+++ b/tools/testing/kunit/qemu_configs/sparc.py
@@ -2,6 +2,7 @@ from ..qemu_config import QemuArchParams
 
 QEMU_ARCH = QemuArchParams(linux_arch='sparc',
 			   kconfig='''
+CONFIG_SPARC32=y
 CONFIG_SERIAL_SUNZILOG=y
 CONFIG_SERIAL_SUNZILOG_CONSOLE=y
 ''',

-- 
2.49.0

Re: [PATCH 1/2] kunit: qemu_configs: sparc: Explicitly enable CONFIG_SPARC32=y
Posted by David Gow 8 months ago
On Tue, 15 Apr 2025 at 21:38, Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> The configuration generated by kunit ends up with a 32bit configuration.
> A new kunit configuration for 64bit is to be added.
> To make the difference clearer spell out the variant in the kunit
> reference config.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---

Thanks.

It looks like the sparc32 configuration can't handle faulting tests,
so I'll send a follow-up to disable CONFIG_KUNIT_FAULT_TEST here as
well.

Otherwise,
Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David


>  tools/testing/kunit/qemu_configs/sparc.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/kunit/qemu_configs/sparc.py b/tools/testing/kunit/qemu_configs/sparc.py
> index 256d9573b44646533d1a6f768976628adc87921e..3131dd299a6e34f027402e99e34d85ddcaa359b7 100644
> --- a/tools/testing/kunit/qemu_configs/sparc.py
> +++ b/tools/testing/kunit/qemu_configs/sparc.py
> @@ -2,6 +2,7 @@ from ..qemu_config import QemuArchParams
>
>  QEMU_ARCH = QemuArchParams(linux_arch='sparc',
>                            kconfig='''
> +CONFIG_SPARC32=y
>  CONFIG_SERIAL_SUNZILOG=y
>  CONFIG_SERIAL_SUNZILOG_CONSOLE=y
>  ''',
>
> --
> 2.49.0
>