[PATCH 1/2] kunit: qemu_configs: powerpc: Explicitly enable CONFIG_CPU_BIG_ENDIAN=y

Thomas Weißschuh posted 2 patches 8 months, 1 week ago
[PATCH 1/2] kunit: qemu_configs: powerpc: Explicitly enable CONFIG_CPU_BIG_ENDIAN=y
Posted by Thomas Weißschuh 8 months, 1 week ago
The configuration generated by kunit ends up with big endian.
A new kunit configuration for little endian is to be added.
To make the difference clearer spell out the endianness in the kunit
reference config.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
 tools/testing/kunit/qemu_configs/powerpc.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/kunit/qemu_configs/powerpc.py b/tools/testing/kunit/qemu_configs/powerpc.py
index 7ec38d4131f7ec3b95d1ec6e49c60a6945be47c8..5b4c895d5d5a2cbcf7e2b987017cbb9f124dd089 100644
--- a/tools/testing/kunit/qemu_configs/powerpc.py
+++ b/tools/testing/kunit/qemu_configs/powerpc.py
@@ -3,6 +3,7 @@ from ..qemu_config import QemuArchParams
 QEMU_ARCH = QemuArchParams(linux_arch='powerpc',
 			   kconfig='''
 CONFIG_PPC64=y
+CONFIG_CPU_BIG_ENDIAN=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_HVC_CONSOLE=y''',

-- 
2.49.0

Re: [PATCH 1/2] kunit: qemu_configs: powerpc: Explicitly enable CONFIG_CPU_BIG_ENDIAN=y
Posted by David Gow 8 months, 1 week ago
On Tue, 15 Apr 2025 at 17:23, Thomas Weißschuh
<thomas.weissschuh@linutronix.de> wrote:
>
> The configuration generated by kunit ends up with big endian.
> A new kunit configuration for little endian is to be added.
> To make the difference clearer spell out the endianness in the kunit
> reference config.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---

Looks good to me, thanks!

Reviewed-by: David Gow <davidgow@google.com>

Cheers,
-- David


>  tools/testing/kunit/qemu_configs/powerpc.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/kunit/qemu_configs/powerpc.py b/tools/testing/kunit/qemu_configs/powerpc.py
> index 7ec38d4131f7ec3b95d1ec6e49c60a6945be47c8..5b4c895d5d5a2cbcf7e2b987017cbb9f124dd089 100644
> --- a/tools/testing/kunit/qemu_configs/powerpc.py
> +++ b/tools/testing/kunit/qemu_configs/powerpc.py
> @@ -3,6 +3,7 @@ from ..qemu_config import QemuArchParams
>  QEMU_ARCH = QemuArchParams(linux_arch='powerpc',
>                            kconfig='''
>  CONFIG_PPC64=y
> +CONFIG_CPU_BIG_ENDIAN=y
>  CONFIG_SERIAL_8250=y
>  CONFIG_SERIAL_8250_CONSOLE=y
>  CONFIG_HVC_CONSOLE=y''',
>
> --
> 2.49.0
>