[v2] USB: serial: ftdi_sio: Code style cleanup

[PATCH v2 RESEND 0/6] USB: serial: ftdi_sio: Code style cleanup

Posted by Dominik Karol Piątkowski 8 months ago

This series fixes spotted code style issues in ftdi_sio driver.

v2: Split the patch into smaller patches

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>

Dominik Karol Piątkowski (6):
  USB: serial: ftdi_sio: Remove space before comma
  USB: serial: ftdi_sio: Add missing blank line after declarations
  USB: serial: ftdi_sio: Remove superfluous space before statements
  USB: serial: ftdi_sio: Fix indentation made with spaces
  USB: serial: ftdi_sio: Fix misaligned block comment
  USB: serial: ftdi_sio: Remove space before tabs

 drivers/usb/serial/ftdi_sio.c     | 16 ++++++++++------
 drivers/usb/serial/ftdi_sio.h     |  2 +-
 drivers/usb/serial/ftdi_sio_ids.h |  4 ++--
 3 files changed, 13 insertions(+), 9 deletions(-)

-- 
2.34.1

Re: [PATCH v2 RESEND 0/6] USB: serial: ftdi_sio: Code style cleanup

Posted by Johan Hovold 7 months ago

On Mon, Apr 14, 2025 at 08:28:10PM +0000, Dominik Karol Piątkowski wrote:
> This series fixes spotted code style issues in ftdi_sio driver.

> Dominik Karol Piątkowski (6):
>   USB: serial: ftdi_sio: Remove space before comma
>   USB: serial: ftdi_sio: Add missing blank line after declarations
>   USB: serial: ftdi_sio: Remove superfluous space before statements
>   USB: serial: ftdi_sio: Fix indentation made with spaces
>   USB: serial: ftdi_sio: Fix misaligned block comment
>   USB: serial: ftdi_sio: Remove space before tabs

You should not be running checkpatch.pl (as you've clearly done here) on
code that's already in the kernel.

The exception is drivers/staging where patches like these are welcome so
that new contributers can practise on creating patches.

Johan