[PATCH] char: xillybus: Use to_delayed_work()

Chen Ni posted 1 patch 10 months ago
drivers/char/xillybus/xillybus_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] char: xillybus: Use to_delayed_work()
Posted by Chen Ni 10 months ago
Use to_delayed_work() instead of open-coding it.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/char/xillybus/xillybus_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
index 11b7c4749274..efb1ae834265 100644
--- a/drivers/char/xillybus/xillybus_core.c
+++ b/drivers/char/xillybus/xillybus_core.c
@@ -1184,8 +1184,7 @@ static int xillybus_flush(struct file *filp, fl_owner_t id)
 
 static void xillybus_autoflush(struct work_struct *work)
 {
-	struct delayed_work *workitem = container_of(
-		work, struct delayed_work, work);
+	struct delayed_work *workitem = to_delayed_work(work);
 	struct xilly_channel *channel = container_of(
 		workitem, struct xilly_channel, rd_workitem);
 	int rc;
-- 
2.25.1
Re: [PATCH] char: xillybus: Use to_delayed_work()
Posted by Eli Billauer 9 months, 4 weeks ago
Yes, I suppose this is the right way to do it.

Thanks,
    Eli

Acked-by: Eli Billauer <eli.billauer@gmail.com>

On 14/04/2025 10:45, Chen Ni wrote:
> Use to_delayed_work() instead of open-coding it.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/char/xillybus/xillybus_core.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
> index 11b7c4749274..efb1ae834265 100644
> --- a/drivers/char/xillybus/xillybus_core.c
> +++ b/drivers/char/xillybus/xillybus_core.c
> @@ -1184,8 +1184,7 @@ static int xillybus_flush(struct file *filp, fl_owner_t id)
>   
>   static void xillybus_autoflush(struct work_struct *work)
>   {
> -	struct delayed_work *workitem = container_of(
> -		work, struct delayed_work, work);
> +	struct delayed_work *workitem = to_delayed_work(work);
>   	struct xilly_channel *channel = container_of(
>   		workitem, struct xilly_channel, rd_workitem);
>   	int rc;