1. Patchew
  2. linux
  3. [PATCH v2 0/2] Reuse the IPQ6018 QUSB2 PHY settings for IPQ5424
  4. View patch

[PATCH v2 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"

Kathiravan Thirumoorthy posted 2 patches 10 months ago
There is a newer version of this series
[PATCH v2 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
Posted by Kathiravan Thirumoorthy 10 months ago 
With the current settings, complaince tests especially eye diagram
(Host High-speed Signal Quality) tests are failing. Design team
requested to reuse the IPQ6018 settings to overcome this issue.

So revert the change which introduced the new settings and reuse the
IPQ6018 settings in the subsequent patch.

Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
---
 drivers/phy/qualcomm/phy-qcom-qusb2.c | 28 ----------------------------
 1 file changed, 28 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 1f5f7df14d5a2ff041fe15aaeb6ec5ce52ab2a81..81b9e9349c3ebb4d303cb040b5c913336bb6b6d6 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl ipq6018_init_tbl[] = {
 	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F),
 };
 
-static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14),
-	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00),
-	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53),
-	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3),
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),
-	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00),
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),
-	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80),
-	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
-};
-
 static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {
 	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),
 	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
@@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = {
 	.autoresume_en   = BIT(0),
 };
 
-static const struct qusb2_phy_cfg ipq5424_phy_cfg = {
-	.tbl            = ipq5424_init_tbl,
-	.tbl_num        = ARRAY_SIZE(ipq5424_init_tbl),
-	.regs           = ipq6018_regs_layout,
-
-	.disable_ctrl   = POWER_DOWN,
-	.mask_core_ready = PLL_LOCKED,
-	.autoresume_en   = BIT(0),
-};
-
 static const struct qusb2_phy_cfg qcs615_phy_cfg = {
 	.tbl            = qcs615_init_tbl,
 	.tbl_num        = ARRAY_SIZE(qcs615_init_tbl),
@@ -954,9 +929,6 @@ static const struct phy_ops qusb2_phy_gen_ops = {
 
 static const struct of_device_id qusb2_phy_of_match_table[] = {
 	{
-		.compatible	= "qcom,ipq5424-qusb2-phy",
-		.data		= &ipq5424_phy_cfg,
-	}, {
 		.compatible	= "qcom,ipq6018-qusb2-phy",
 		.data		= &ipq6018_phy_cfg,
 	}, {

-- 
2.34.1
Re: [PATCH v2 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
Posted by Mukesh Kumar Savaliya 10 months ago 

On 4/14/2025 5:22 PM, Kathiravan Thirumoorthy wrote:
> With the current settings, complaince tests especially eye diagram
compliance
> (Host High-speed Signal Quality) tests are failing. Design team
Write it as "recommended by Hardware design document/guide" instead of 
design team.
> requested to reuse the IPQ6018 settings to overcome this issue.
> 
> So revert the change which introduced the new settings and reuse the
> IPQ6018 settings in the subsequent patch.
> 
> Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
> Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
> ---
>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 28 ----------------------------
>   1 file changed, 28 deletions(-)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> index 1f5f7df14d5a2ff041fe15aaeb6ec5ce52ab2a81..81b9e9349c3ebb4d303cb040b5c913336bb6b6d6 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
> @@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl ipq6018_init_tbl[] = {
>   	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F),
>   };
>   
> -static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14),
> -	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00),
> -	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53),
> -	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3),
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),
> -	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00),
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),
> -	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80),
> -	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
> -};
> -
>   static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {
>   	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),
>   	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
> @@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg ipq6018_phy_cfg = {
>   	.autoresume_en   = BIT(0),
>   };
>   
> -static const struct qusb2_phy_cfg ipq5424_phy_cfg = {
> -	.tbl            = ipq5424_init_tbl,
> -	.tbl_num        = ARRAY_SIZE(ipq5424_init_tbl),
> -	.regs           = ipq6018_regs_layout,
> -
> -	.disable_ctrl   = POWER_DOWN,
> -	.mask_core_ready = PLL_LOCKED,
> -	.autoresume_en   = BIT(0),
> -};
> -
>   static const struct qusb2_phy_cfg qcs615_phy_cfg = {
>   	.tbl            = qcs615_init_tbl,
>   	.tbl_num        = ARRAY_SIZE(qcs615_init_tbl),
> @@ -954,9 +929,6 @@ static const struct phy_ops qusb2_phy_gen_ops = {
>   
>   static const struct of_device_id qusb2_phy_of_match_table[] = {
>   	{
> -		.compatible	= "qcom,ipq5424-qusb2-phy",
> -		.data		= &ipq5424_phy_cfg,
> -	}, {
>   		.compatible	= "qcom,ipq6018-qusb2-phy",
>   		.data		= &ipq6018_phy_cfg,
>   	}, {
>
Re: [PATCH v2 1/2] Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"
Posted by Kathiravan Thirumoorthy 10 months ago 
On 4/14/2025 7:03 PM, Mukesh Kumar Savaliya wrote:
>
>
> On 4/14/2025 5:22 PM, Kathiravan Thirumoorthy wrote:
>> With the current settings, complaince tests especially eye diagram
> compliance


Ack.


>> (Host High-speed Signal Quality) tests are failing. Design team
> Write it as "recommended by Hardware design document/guide" instead of 
> design team.


Ack.


>> requested to reuse the IPQ6018 settings to overcome this issue.
>>
>> So revert the change which introduced the new settings and reuse the
>> IPQ6018 settings in the subsequent patch.
>>
>> Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
>> Signed-off-by: Kathiravan Thirumoorthy 
>> <kathiravan.thirumoorthy@oss.qualcomm.com>
>> ---
>>   drivers/phy/qualcomm/phy-qcom-qusb2.c | 28 
>> ----------------------------
>>   1 file changed, 28 deletions(-)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c 
>> b/drivers/phy/qualcomm/phy-qcom-qusb2.c
>> index 
>> 1f5f7df14d5a2ff041fe15aaeb6ec5ce52ab2a81..81b9e9349c3ebb4d303cb040b5c913336bb6b6d6 
>> 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
>> @@ -151,21 +151,6 @@ static const struct qusb2_phy_init_tbl 
>> ipq6018_init_tbl[] = {
>>       QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F),
>>   };
>>   -static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14),
>> -    QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00),
>> -    QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53),
>> -    QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3),
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),
>> -    QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00),
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),
>> -    QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80),
>> -    QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
>> -};
>> -
>>   static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {
>>       QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),
>>       QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
>> @@ -359,16 +344,6 @@ static const struct qusb2_phy_cfg 
>> ipq6018_phy_cfg = {
>>       .autoresume_en   = BIT(0),
>>   };
>>   -static const struct qusb2_phy_cfg ipq5424_phy_cfg = {
>> -    .tbl            = ipq5424_init_tbl,
>> -    .tbl_num        = ARRAY_SIZE(ipq5424_init_tbl),
>> -    .regs           = ipq6018_regs_layout,
>> -
>> -    .disable_ctrl   = POWER_DOWN,
>> -    .mask_core_ready = PLL_LOCKED,
>> -    .autoresume_en   = BIT(0),
>> -};
>> -
>>   static const struct qusb2_phy_cfg qcs615_phy_cfg = {
>>       .tbl            = qcs615_init_tbl,
>>       .tbl_num        = ARRAY_SIZE(qcs615_init_tbl),
>> @@ -954,9 +929,6 @@ static const struct phy_ops qusb2_phy_gen_ops = {
>>     static const struct of_device_id qusb2_phy_of_match_table[] = {
>>       {
>> -        .compatible    = "qcom,ipq5424-qusb2-phy",
>> -        .data        = &ipq5424_phy_cfg,
>> -    }, {
>>           .compatible    = "qcom,ipq6018-qusb2-phy",
>>           .data        = &ipq6018_phy_cfg,
>>       }, {
>>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.