soc: samsung: usi: prevent wrong bits inversion during unconfiguring

[PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring

Posted by Ivaylo Ivanov 10 months ago

Instead of setting bit 1 (USI_OPTION_CLKSTOP_ON) during USI unconfiguring,
all the other bits in the USI_OPTION register get inverted, which
should not happen as that means the clock will keep getting provided
to the USI IP. Remove the unnecessary tilde.

Fixes: 11e77776b58a ("soc: samsung: usi: add a routine for unconfiguring the ip")
Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
 drivers/soc/samsung/exynos-usi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/samsung/exynos-usi.c b/drivers/soc/samsung/exynos-usi.c
index c5661ac19..5f7bdf3ba 100644
--- a/drivers/soc/samsung/exynos-usi.c
+++ b/drivers/soc/samsung/exynos-usi.c
@@ -233,7 +233,7 @@ static void exynos_usi_unconfigure(void *data)
 	/* Make sure that we've stopped providing the clock to USI IP */
 	val = readl(usi->regs + USI_OPTION);
 	val &= ~USI_OPTION_CLKREQ_ON;
-	val |= ~USI_OPTION_CLKSTOP_ON;
+	val |= USI_OPTION_CLKSTOP_ON;
 	writel(val, usi->regs + USI_OPTION);
 
 	/* Set USI block state to reset */
-- 
2.43.0

Re: [PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring

Posted by Krzysztof Kozlowski 10 months ago

On 13/04/2025 18:37, Ivaylo Ivanov wrote:
> Instead of setting bit 1 (USI_OPTION_CLKSTOP_ON) during USI unconfiguring,
> all the other bits in the USI_OPTION register get inverted, which
> should not happen as that means the clock will keep getting provided
> to the USI IP. Remove the unnecessary tilde.
> 
> Fixes: 11e77776b58a ("soc: samsung: usi: add a routine for unconfiguring the ip")
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---

Thanks, applied.

Best regards,
Krzysztof