[PATCH v2 0/4] staging: greybus: cleanup, API migration, and refactors

Ganesh Kumar Pittala posted 4 patches 8 months, 1 week ago
.../greybus/Documentation/firmware/firmware.c |   6 +-
drivers/staging/greybus/arche-apb-ctrl.c      |  11 +-
drivers/staging/greybus/arche-platform.c      |  11 +-
drivers/staging/greybus/audio_gb.c            |  36 +++-
.../staging/greybus/audio_manager_module.c    |  13 +-
drivers/staging/greybus/gbphy.c               |   3 +-
drivers/staging/greybus/light.c               |   5 +-
drivers/staging/greybus/loopback.c            | 167 ++++++++++--------
8 files changed, 145 insertions(+), 107 deletions(-)
[PATCH v2 0/4] staging: greybus: cleanup, API migration, and refactors
Posted by Ganesh Kumar Pittala 8 months, 1 week ago
This patch series splits and improves the previously submitted single patch by
breaking it into four independent, logical changes following kernel submission
etiquette.

Link: https://lore.kernel.org/r/d683962c-e8b7-4adc-9902-483976197637@riscstar.com
Link: https://lore.kernel.org/r/5773d200-1d9d-4d6e-b01e-10d962ee9e8e@quicinc.com
Link: https://lore.kernel.org/r/4f47df18-e98c-4f23-afde-3fa8e9fd0f86@quicinc.com
Link: https://lore.kernel.org/r/202504010829.vIzweYue-lkp@intel.com
Link: https://lore.kernel.org/r/202504011217.iRb2Bbls-lkp@intel.com

All changes are isolated, reviewed, and tested.

Patches included:
  1. Replace deprecated strncpy() with strscpy() in firmware.c
  2. Replace sprintf() with sysfs_emit() in sysfs show functions
  3. Refactor gb_loopback_fn() into smaller helpers
  4. Fulfill TODO by splitting get_topology() logic in audio_gb.c

v1 feedback from maintainers highlighted the need to split changes and avoid
unrelated whitespace or formatting edits. These recommendations have been
carefully addressed in this version.

Signed-off-by: Ganesh Kumar Pittala <ganeshkpittala@gmail.com>

Ganesh Kumar Pittala (4):
  staging: greybus: replace deprecated strncpy with strscpy in
    firmware.c
  staging: greybus: replace sprintf with sysfs_emit in sysfs show
    functions
  staging: greybus: refactor gb_loopback_fn into smaller helper
    functions
  staging: greybus: split gb_audio_gb_get_topology into helper functions

 .../greybus/Documentation/firmware/firmware.c |   6 +-
 drivers/staging/greybus/arche-apb-ctrl.c      |  11 +-
 drivers/staging/greybus/arche-platform.c      |  11 +-
 drivers/staging/greybus/audio_gb.c            |  36 +++-
 .../staging/greybus/audio_manager_module.c    |  13 +-
 drivers/staging/greybus/gbphy.c               |   3 +-
 drivers/staging/greybus/light.c               |   5 +-
 drivers/staging/greybus/loopback.c            | 167 ++++++++++--------
 8 files changed, 145 insertions(+), 107 deletions(-)

-- 
2.43.0
Re: [PATCH v2 0/4] staging: greybus: cleanup, API migration, and refactors
Posted by Greg KH 8 months ago
On Sun, Apr 13, 2025 at 07:32:16AM +0000, Ganesh Kumar Pittala wrote:
> This patch series splits and improves the previously submitted single patch by
> breaking it into four independent, logical changes following kernel submission
> etiquette.
> 
> Link: https://lore.kernel.org/r/d683962c-e8b7-4adc-9902-483976197637@riscstar.com
> Link: https://lore.kernel.org/r/5773d200-1d9d-4d6e-b01e-10d962ee9e8e@quicinc.com
> Link: https://lore.kernel.org/r/4f47df18-e98c-4f23-afde-3fa8e9fd0f86@quicinc.com
> Link: https://lore.kernel.org/r/202504010829.vIzweYue-lkp@intel.com
> Link: https://lore.kernel.org/r/202504011217.iRb2Bbls-lkp@intel.com
> 
> All changes are isolated, reviewed, and tested.

How exactly did you test these?  What hardware was it run on?

thanks,

greg k-h