[PATCH 1/2] dt-bindings: pinctrl: spacemit: add clock and reset property

Yixun Lan posted 2 patches 10 months ago
There is a newer version of this series
[PATCH 1/2] dt-bindings: pinctrl: spacemit: add clock and reset property
Posted by Yixun Lan 10 months ago
SpacemiT K1 SoC's pinctrl controller requires two clocks in order
to work propertly, also has one reset line from hardware persepective.

Signed-off-by: Yixun Lan <dlan@gentoo.org>
---
 .../bindings/pinctrl/spacemit,k1-pinctrl.yaml          | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
index b01ecd83b71b5e9f47256adde23bc8b183bef05e..d80e88aa07b45f4a3d90e8217caf93d32655927d 100644
--- a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
@@ -17,6 +17,19 @@ properties:
     items:
       - description: pinctrl io memory base
 
+  clocks:
+    items:
+      - description: Functional Clock
+      - description: Bus Clock
+
+  clock-names:
+    items:
+      - const: func
+      - const: bus
+
+  resets:
+    maxItems: 1
+
 patternProperties:
   '-cfg$':
     type: object
@@ -94,6 +107,8 @@ patternProperties:
 required:
   - compatible
   - reg
+  - clocks
+  - clock-names
 
 additionalProperties: false
 
@@ -108,6 +123,9 @@ examples:
         pinctrl@d401e000 {
             compatible = "spacemit,k1-pinctrl";
             reg = <0x0 0xd401e000 0x0 0x400>;
+            clocks = <&syscon_apbc 42>,
+                     <&syscon_apbc 94>;
+            clock-names = "func", "bus";
 
             uart0_2_cfg: uart0-2-cfg {
                 uart0-2-pins {

-- 
2.49.0
Re: [PATCH 1/2] dt-bindings: pinctrl: spacemit: add clock and reset property
Posted by ALOK TIWARI 10 months ago

On 12-04-2025 12:28, Yixun Lan wrote:
> SpacemiT K1 SoC's pinctrl controller requires two clocks in order
> to work propertly, also has one reset line from hardware persepective.

typo in commit message
propertly -> properly
persepective -> perspective

> 
> Signed-off-by: Yixun Lan<dlan@gentoo.org>
> ---
>   .../bindings/pinctrl/spacemit,k1-pinctrl.yaml


Thanks,
Alok
Re: [PATCH 1/2] dt-bindings: pinctrl: spacemit: add clock and reset property
Posted by Yixun Lan 10 months ago
Hi ALOK,

On 17:01 Sat 12 Apr     , ALOK TIWARI wrote:
> 
> 
> On 12-04-2025 12:28, Yixun Lan wrote:
> > SpacemiT K1 SoC's pinctrl controller requires two clocks in order
> > to work propertly, also has one reset line from hardware persepective.
> 
> typo in commit message
> propertly -> properly
> persepective -> perspective
> 
thanks for catching this..
will wait for more comments, and fix in next version

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55