[PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING

Liam R. Howlett posted 1 patch 10 months ago
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
[PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Posted by Liam R. Howlett 10 months ago
MEMORY MAPPING does not list the mmap.h trace point file, but does list
the mmap.c file.  Couple the trace points with the users and authors of
the trace points for notifications of updates.

Cc:Andrew Morton <akpm@linux-foundation.org>
Cc:Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc:Vlastimil Babka <vbabka@suse.cz>
Cc:Jann Horn <jannh@google.com>
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4c7fdc41a6bfb..d8e9a10adc81d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/trace/events/mmap.h
 F:	mm/mlock.c
 F:	mm/mmap.c
 F:	mm/mprotect.c
-- 
2.43.0
Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Posted by Vlastimil Babka 9 months, 4 weeks ago
On 4/11/25 19:33, Liam R. Howlett wrote:
> MEMORY MAPPING does not list the mmap.h trace point file, but does list
> the mmap.c file.  Couple the trace points with the users and authors of
> the trace points for notifications of updates.
> 
> Cc:Andrew Morton <akpm@linux-foundation.org>
> Cc:Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc:Vlastimil Babka <vbabka@suse.cz>
> Cc:Jann Horn <jannh@google.com>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
>  S:	Maintained
>  W:	http://www.linux-mm.org
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/trace/events/mmap.h
>  F:	mm/mlock.c
>  F:	mm/mmap.c
>  F:	mm/mprotect.c
Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Posted by Steven Rostedt 10 months ago
On Fri, 11 Apr 2025 13:33:28 -0400
"Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:

> MEMORY MAPPING does not list the mmap.h trace point file, but does list
> the mmap.c file.  Couple the trace points with the users and authors of
> the trace points for notifications of updates.
> 
> Cc:Andrew Morton <akpm@linux-foundation.org>
> Cc:Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc:Vlastimil Babka <vbabka@suse.cz>
> Cc:Jann Horn <jannh@google.com>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
>  S:	Maintained
>  W:	http://www.linux-mm.org
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/trace/events/mmap.h

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

>  F:	mm/mlock.c
>  F:	mm/mmap.c
>  F:	mm/mprotect.c
Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Posted by SeongJae Park 10 months ago
On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:

> MEMORY MAPPING does not list the mmap.h trace point file, but does list
> the mmap.c file.  Couple the trace points with the users and authors of
> the trace points for notifications of updates.
> 
> Cc:Andrew Morton <akpm@linux-foundation.org>
> Cc:Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc:Vlastimil Babka <vbabka@suse.cz>
> Cc:Jann Horn <jannh@google.com>
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>

Aced-by: SeongJae Park <sj@kernel.org>

> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
>  S:	Maintained
>  W:	http://www.linux-mm.org
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/trace/events/mmap.h

Should mmap_lock.h also be added here?

>  F:	mm/mlock.c
>  F:	mm/mmap.c
>  F:	mm/mprotect.c
> -- 
> 2.43.0


Thanks,
SJ
Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Posted by Liam R. Howlett 10 months ago
* SeongJae Park <sj@kernel.org> [250411 13:47]:
> On Fri, 11 Apr 2025 13:33:28 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
> 
> > MEMORY MAPPING does not list the mmap.h trace point file, but does list
> > the mmap.c file.  Couple the trace points with the users and authors of
> > the trace points for notifications of updates.
> > 
> > Cc:Andrew Morton <akpm@linux-foundation.org>
> > Cc:Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > Cc:Vlastimil Babka <vbabka@suse.cz>
> > Cc:Jann Horn <jannh@google.com>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> 
> Aced-by: SeongJae Park <sj@kernel.org>
> 
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 4c7fdc41a6bfb..d8e9a10adc81d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
> >  S:	Maintained
> >  W:	http://www.linux-mm.org
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	include/trace/events/mmap.h
> 
> Should mmap_lock.h also be added here?

Oh, well..

mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
mm/mmap_lock.c, which also isn't listed here.  Both exist for tracing as
well.

There is also include/linux/mmap_lock.h, which is the locking itself.
The mmap lock is used more broadly than just these files: mm/pagewalk.c
and mm/ksm.c, for instance.

So I guess that's a more difficult decision.

Thanks for bringing this up,
Liam
Re: [PATCH] MAINTAINERS: Add mmap trace events to MEMORY MAPPING
Posted by SeongJae Park 10 months ago
On Sat, 12 Apr 2025 09:17:21 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:

> * SeongJae Park <sj@kernel.org> [250411 13:47]:
[...]
> > > @@ -15571,6 +15571,7 @@ L:	linux-mm@kvack.org
> > >  S:	Maintained
> > >  W:	http://www.linux-mm.org
> > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > > +F:	include/trace/events/mmap.h
> > 
> > Should mmap_lock.h also be added here?
> 
> Oh, well..
> 
> mmap_lock.h (include/trace/events/mmap_lock.h) has to do with
> mm/mmap_lock.c, which also isn't listed here.  Both exist for tracing as
> well.
> 
> There is also include/linux/mmap_lock.h, which is the locking itself.
> The mmap lock is used more broadly than just these files: mm/pagewalk.c
> and mm/ksm.c, for instance.
> 
> So I guess that's a more difficult decision.

Makes perfect sense.  Thank you for kindly clarifying this.


Thanks,
SJ

[...]