Fix up building KUnit tests for Cirrus Logic modules

[PATCH 0/3] Fix up building KUnit tests for Cirrus Logic modules

Posted by Richard Fitzgerald 8 months, 1 week ago

This series fixes the KConfig for cs_dsp and cs-amp-lib tests so that
CONFIG_KUNIT_ALL_TESTS doesn't cause them to add modules to the build.

Patch 1 adds the ASoC CS35L56 driver to KUnit all_tests.config so that
        cs_dsp and cs-amp-lib will be included in the test build.

Patch 2 and 3 fixup the KConfig entries for cs_dsp and cs-amp-lib.

Nico Pache (1):
  firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it

Richard Fitzgerald (2):
  kunit: configs: Add some Cirrus Logic modules to all_tests
  ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB

 drivers/firmware/cirrus/Kconfig              | 5 +----
 sound/soc/codecs/Kconfig                     | 5 ++---
 tools/testing/kunit/configs/all_tests.config | 2 ++
 3 files changed, 5 insertions(+), 7 deletions(-)

-- 
2.39.5

Re: [PATCH 0/3] Fix up building KUnit tests for Cirrus Logic modules

Posted by Mark Brown 8 months, 1 week ago

On Fri, 11 Apr 2025 13:36:05 +0100, Richard Fitzgerald wrote:
> This series fixes the KConfig for cs_dsp and cs-amp-lib tests so that
> CONFIG_KUNIT_ALL_TESTS doesn't cause them to add modules to the build.
> 
> Patch 1 adds the ASoC CS35L56 driver to KUnit all_tests.config so that
>         cs_dsp and cs-amp-lib will be included in the test build.
> 
> Patch 2 and 3 fixup the KConfig entries for cs_dsp and cs-amp-lib.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] kunit: configs: Add some Cirrus Logic modules to all_tests
      commit: 1aa495a6572f8641da4ec4cd32210deca61bed64
[2/3] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB
      commit: 96014d91cffb335d3b396771524ff2aba3549865
[3/3] firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it
      commit: a0b887f6eb9a0d1be3c57d00b0f3ba8408d3018a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH 0/3] Fix up building KUnit tests for Cirrus Logic modules

Posted by David Gow 8 months, 1 week ago

On Fri, 11 Apr 2025 at 20:36, Richard Fitzgerald
<rf@opensource.cirrus.com> wrote:
>
> This series fixes the KConfig for cs_dsp and cs-amp-lib tests so that
> CONFIG_KUNIT_ALL_TESTS doesn't cause them to add modules to the build.
>
> Patch 1 adds the ASoC CS35L56 driver to KUnit all_tests.config so that
>         cs_dsp and cs-amp-lib will be included in the test build.
>
> Patch 2 and 3 fixup the KConfig entries for cs_dsp and cs-amp-lib.

This looks great to me.

The series is:
Reviewed-by: David Gow <davidgow@google.com>


Do you want us to take this (either the whole thing, or just the first
patch) via the KUnit tree, or will you take it yourself? Either should
work here.

Cheers,
-- David

>
> Nico Pache (1):
>   firmware: cs_dsp: tests: Depend on FW_CS_DSP rather then enabling it
>
> Richard Fitzgerald (2):
>   kunit: configs: Add some Cirrus Logic modules to all_tests
>   ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB
>
>  drivers/firmware/cirrus/Kconfig              | 5 +----
>  sound/soc/codecs/Kconfig                     | 5 ++---
>  tools/testing/kunit/configs/all_tests.config | 2 ++
>  3 files changed, 5 insertions(+), 7 deletions(-)
>
> --
> 2.39.5
>