[PATCH V3 0/2] scsi: ufs: Implement Quirks for Samsung UFS Devices

Manish Pandey posted 2 patches 8 months, 1 week ago
drivers/ufs/core/ufshcd.c   | 29 +++++++++++++++++++++++++
drivers/ufs/host/ufs-qcom.c | 43 +++++++++++++++++++++++++++++++++++++
drivers/ufs/host/ufs-qcom.h | 18 ++++++++++++++++
include/ufs/ufs_quirks.h    |  6 ++++++
4 files changed, 96 insertions(+)
[PATCH V3 0/2] scsi: ufs: Implement Quirks for Samsung UFS Devices
Posted by Manish Pandey 8 months, 1 week ago
Introduce quirks for Samsung UFS devices to modify the PA TX HSG1 sync
length and TX_HS_EQUALIZER settings on the Qualcomm UFS Host controller.

Additionally, Samsung UFS devices require extra time in hibern8 mode
before exiting, beyond the standard handshaking phase between the host
and device. Introduce a quirk to increase the PA_HIBERN8TIME parameter
by 100 µs to ensure a proper hibernation process.
---
Changes in V3
- Addressed Mani's comment and updated commit message.
- used BIT macro in ufs-qcom.h to define quirks.
Changes in V2
- Split patches to add PA_HIBERN8TIME quirk in ufshcd.c

---
Manish Pandey (2):
  ufs: qcom: Add quirks for Samsung UFS devices
  scsi: ufs: introduce quirk to extend PA_HIBERN8TIME for UFS devices

 drivers/ufs/core/ufshcd.c   | 29 +++++++++++++++++++++++++
 drivers/ufs/host/ufs-qcom.c | 43 +++++++++++++++++++++++++++++++++++++
 drivers/ufs/host/ufs-qcom.h | 18 ++++++++++++++++
 include/ufs/ufs_quirks.h    |  6 ++++++
 4 files changed, 96 insertions(+)

-- 
2.17.1

Re: [PATCH V3 0/2] scsi: ufs: Implement Quirks for Samsung UFS Devices
Posted by Martin K. Petersen 8 months ago
On Fri, 11 Apr 2025 17:46:28 +0530, Manish Pandey wrote:

> Introduce quirks for Samsung UFS devices to modify the PA TX HSG1 sync
> length and TX_HS_EQUALIZER settings on the Qualcomm UFS Host controller.
> 
> Additionally, Samsung UFS devices require extra time in hibern8 mode
> before exiting, beyond the standard handshaking phase between the host
> and device. Introduce a quirk to increase the PA_HIBERN8TIME parameter
> by 100 µs to ensure a proper hibernation process.
> 
> [...]

Applied to 6.15/scsi-fixes, thanks!

[1/2] ufs: qcom: Add quirks for Samsung UFS devices
      https://git.kernel.org/mkp/scsi/c/f8cba9a700cf
[2/2] scsi: ufs: introduce quirk to extend PA_HIBERN8TIME for UFS devices
      https://git.kernel.org/mkp/scsi/c/569330a34a31

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH V3 0/2] scsi: ufs: Implement Quirks for Samsung UFS Devices
Posted by Martin K. Petersen 8 months, 1 week ago
On Fri, 11 Apr 2025 17:46:28 +0530, Manish Pandey wrote:

> Introduce quirks for Samsung UFS devices to modify the PA TX HSG1 sync
> length and TX_HS_EQUALIZER settings on the Qualcomm UFS Host controller.
> 
> Additionally, Samsung UFS devices require extra time in hibern8 mode
> before exiting, beyond the standard handshaking phase between the host
> and device. Introduce a quirk to increase the PA_HIBERN8TIME parameter
> by 100 µs to ensure a proper hibernation process.
> 
> [...]

Applied to 6.15/scsi-fixes, thanks!

[1/2] ufs: qcom: Add quirks for Samsung UFS devices
      https://git.kernel.org/mkp/scsi/c/f8cba9a700cf
[2/2] scsi: ufs: introduce quirk to extend PA_HIBERN8TIME for UFS devices
      https://git.kernel.org/mkp/scsi/c/569330a34a31

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH V3 0/2] scsi: ufs: Implement Quirks for Samsung UFS Devices
Posted by Manivannan Sadhasivam 8 months, 1 week ago
On Fri, Apr 11, 2025 at 05:46:28PM +0530, Manish Pandey wrote:
> Introduce quirks for Samsung UFS devices to modify the PA TX HSG1 sync
> length and TX_HS_EQUALIZER settings on the Qualcomm UFS Host controller.
> 
> Additionally, Samsung UFS devices require extra time in hibern8 mode
> before exiting, beyond the standard handshaking phase between the host
> and device. Introduce a quirk to increase the PA_HIBERN8TIME parameter
> by 100 µs to ensure a proper hibernation process.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
> Changes in V3
> - Addressed Mani's comment and updated commit message.
> - used BIT macro in ufs-qcom.h to define quirks.
> Changes in V2
> - Split patches to add PA_HIBERN8TIME quirk in ufshcd.c
> 
> ---
> Manish Pandey (2):
>   ufs: qcom: Add quirks for Samsung UFS devices
>   scsi: ufs: introduce quirk to extend PA_HIBERN8TIME for UFS devices
> 
>  drivers/ufs/core/ufshcd.c   | 29 +++++++++++++++++++++++++
>  drivers/ufs/host/ufs-qcom.c | 43 +++++++++++++++++++++++++++++++++++++
>  drivers/ufs/host/ufs-qcom.h | 18 ++++++++++++++++
>  include/ufs/ufs_quirks.h    |  6 ++++++
>  4 files changed, 96 insertions(+)
> 
> -- 
> 2.17.1
> 

-- 
மணிவண்ணன் சதாசிவம்