[v2] drm/bridge: dw-hdmi: Avoid including uapi headers

[PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

Posted by Andy Yan 8 months, 1 week ago

From: Andy Yan <andy.yan@rock-chips.com>

It is not recommended for drivers to include UAPI header
directly.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

---

Changes in v2:
- Collect R-b from Heiko.

 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index b1cdf806b3c40..deaba3b6f9978 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -22,8 +22,8 @@
 
 #include <media/cec-notifier.h>
 
-#include <uapi/linux/media-bus-format.h>
-#include <uapi/linux/videodev2.h>
+#include <linux/media-bus-format.h>
+#include <linux/videodev2.h>
 
 #include <drm/bridge/dw_hdmi.h>
 #include <drm/display/drm_hdmi_helper.h>
-- 
2.43.0

Re: [PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

Posted by Dmitry Baryshkov 8 months ago

On Fri, 11 Apr 2025 19:59:37 +0800, Andy Yan wrote:
> It is not recommended for drivers to include UAPI header
> directly.
> 
> 

Applied to drm-misc-next, thanks!

[1/1] drm/bridge: dw-hdmi: Avoid including uapi headers
      commit: 4890d68db651562ea80250f2c93205a5c0327a6a

Best regards,
-- 
With best wishes
Dmitry

Re: [PATCH v2] drm/bridge: dw-hdmi: Avoid including uapi headers

Posted by neil.armstrong@linaro.org 8 months, 1 week ago

On 11/04/2025 13:59, Andy Yan wrote:
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> It is not recommended for drivers to include UAPI header
> directly.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> 
> ---
> 
> Changes in v2:
> - Collect R-b from Heiko.
> 
>   drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index b1cdf806b3c40..deaba3b6f9978 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -22,8 +22,8 @@
>   
>   #include <media/cec-notifier.h>
>   
> -#include <uapi/linux/media-bus-format.h>
> -#include <uapi/linux/videodev2.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/videodev2.h>
>   
>   #include <drm/bridge/dw_hdmi.h>
>   #include <drm/display/drm_hdmi_helper.h>

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>