arm64: dts: ti: k3-j721e-common-proc-board: Add bootph-all to HBMC nodes

[PATCH] arm64: dts: ti: k3-j721e-common-proc-board: Add bootph-all to HBMC nodes

Posted by Anurag Dutta 10 months ago

Add bootph-all to HBMC controller and hyperflash nodes for successful
hyperflash boot on j721e-evm.

Signed-off-by: Anurag Dutta <a-dutta@ti.com>
---

Test logs : https://gist.github.com/anuragdutta731/90a492589557c2ec2881e1de50a62006

 arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 4421852161dd..9ada749f16ba 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -570,6 +570,13 @@ &usb1 {
 	maximum-speed = "high-speed";
 };
 
+&hbmc {
+	bootph-all;
+	flash@0,0 {
+		bootph-all;
+	};
+};
+
 &ospi1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mcu_fss0_ospi1_pins_default>;
-- 
2.34.1

Re: [PATCH] arm64: dts: ti: k3-j721e-common-proc-board: Add bootph-all to HBMC nodes

Posted by Kumar, Udit 9 months, 3 weeks ago

On 4/11/2025 1:56 PM, Anurag Dutta wrote:
> Add bootph-all to HBMC controller and hyperflash nodes for successful
> hyperflash boot on j721e-evm.
>
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---
>
> Test logs : https://gist.github.com/anuragdutta731/90a492589557c2ec2881e1de50a62006
>
>   arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 4421852161dd..9ada749f16ba 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -570,6 +570,13 @@ &usb1 {
>   	maximum-speed = "high-speed";
>   };
>   
> +&hbmc {
> +	bootph-all;
> +	flash@0,0 {
> +		bootph-all;
> +	};
> +};

Could you check once , if this is duplicated

commit fbdb8aa4eab84 "arm64: dts: ti: k3-j721e-evm*: Add bootph-* 
properties"

adds bootph-all in arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi file for 
flash.

AFAIK, parent node should inherit property of child for bootph.

In case you are not getting in u-boot then u-boot shall fix this[0]

[0] : https://lore.kernel.org/all/20250327080642.2269856-1-m-shah@ti.com/

> +
>   &ospi1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&mcu_fss0_ospi1_pins_default>;

Re: [PATCH] arm64: dts: ti: k3-j721e-common-proc-board: Add bootph-all to HBMC nodes

Posted by Nishanth Menon 10 months ago

On 13:56-20250411, Anurag Dutta wrote:
> Add bootph-all to HBMC controller and hyperflash nodes for successful
> hyperflash boot on j721e-evm.
> 
> Signed-off-by: Anurag Dutta <a-dutta@ti.com>
> ---
> 
> Test logs : https://gist.github.com/anuragdutta731/90a492589557c2ec2881e1de50a62006
> 
>  arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> index 4421852161dd..9ada749f16ba 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> @@ -570,6 +570,13 @@ &usb1 {
>  	maximum-speed = "high-speed";
>  };
>  
> +&hbmc {
> +	bootph-all;

Documentation/devicetree/bindings/dts-coding-style.rst
Please add an EoL

> +	flash@0,0 {
> +		bootph-all;
> +	};
> +};

Why &hbmc, why not in the SoM.dtsi?

> +
>  &ospi1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&mcu_fss0_ospi1_pins_default>;
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D