mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error

[PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error

Posted by Yue Haibing 10 months ago

If COMPILE_TEST is y but RISCV_SBI is n, build fails:

drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
	struct sbiret ret;
	              ^~~
  CC      drivers/nvmem/lpc18xx_otp.o
drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
	ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
	      ^~~~~~~~~

move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.

Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/mailbox/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
index ed52db272f4d..e8445cda7c61 100644
--- a/drivers/mailbox/Kconfig
+++ b/drivers/mailbox/Kconfig
@@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
 
 config MCHP_SBI_IPC_MBOX
 	tristate "Microchip Inter-processor Communication (IPC) SBI driver"
-	depends on RISCV_SBI || COMPILE_TEST
-	depends on ARCH_MICROCHIP
+	depends on RISCV_SBI
+	depends on ARCH_MICROCHIP || COMPILE_TEST
 	help
 	  Mailbox implementation for Microchip devices with an
 	  Inter-process communication (IPC) controller.
-- 
2.34.1

Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error

Posted by Yue Haibing 9 months ago

ping..

On 2025/4/11 15:57, Yue Haibing wrote:
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
> 
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
> 	struct sbiret ret;
> 	              ^~~
>   CC      drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
> 	ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
> 	      ^~~~~~~~~
> 
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
> 
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  drivers/mailbox/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
>  
>  config MCHP_SBI_IPC_MBOX
>  	tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> -	depends on RISCV_SBI || COMPILE_TEST
> -	depends on ARCH_MICROCHIP
> +	depends on RISCV_SBI
> +	depends on ARCH_MICROCHIP || COMPILE_TEST
>  	help
>  	  Mailbox implementation for Microchip devices with an
>  	  Inter-process communication (IPC) controller.

Re: [PATCH -next] mailbox: mchp-ipc-sbi: Fix COMPILE_TEST build error

Posted by Valentina.FernandezAlanis@microchip.com 10 months ago

On 11/04/2025 08:57, Yue Haibing wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> If COMPILE_TEST is y but RISCV_SBI is n, build fails:
> 
> drivers/mailbox/mailbox-mchp-ipc-sbi.c: In function ‘mchp_ipc_sbi_chan_send’:
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:119:23: error: storage size of ‘ret’ isn’t known
>          struct sbiret ret;
>                        ^~~
>    CC      drivers/nvmem/lpc18xx_otp.o
> drivers/mailbox/mailbox-mchp-ipc-sbi.c:121:15: error: implicit declaration of function ‘sbi_ecall’ [-Werror=implicit-function-declaration]
>          ret = sbi_ecall(SBI_EXT_MICROCHIP_TECHNOLOGY, command, channel,
>                ^~~~~~~~~
> 
> move COMPILE_TEST to ARCH_MICROCHIP dependency as other drivers.
> 
> Fixes: e4b1d67e7141 ("mailbox: add Microchip IPC support")
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Acked-by: Valentina Fernandez <valentina.fernandezalanis@microchip.com>
> ---
>   drivers/mailbox/Kconfig | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index ed52db272f4d..e8445cda7c61 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -191,8 +191,8 @@ config POLARFIRE_SOC_MAILBOX
> 
>   config MCHP_SBI_IPC_MBOX
>          tristate "Microchip Inter-processor Communication (IPC) SBI driver"
> -       depends on RISCV_SBI || COMPILE_TEST
> -       depends on ARCH_MICROCHIP
> +       depends on RISCV_SBI
> +       depends on ARCH_MICROCHIP || COMPILE_TEST
>          help
>            Mailbox implementation for Microchip devices with an
>            Inter-process communication (IPC) controller.
> --
> 2.34.1
>