tools/include/nolibc/types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Fix an imbalance where opening parentheses exceed closing ones.
Fixes: eba6d00d38e7c ("tools/nolibc/types: move makedev to types.h and make it a macro")
Signed-off-by: Jemmy Wong <jemmywong512@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
---
Changes in v3:
- Fix identity of sender and Signed-off-by
- Add Fixes tag
Changes in v2:
- https://lore.kernel.org/all/20250409191436.75658-1-jemmywong512@gmail.com/
- Formalize patch commit msg
- Add subject prefix: "tools/nolibc/types.h:"
Changes in v1:
- https://lore.kernel.org/all/20250409181934.5589-1-jemmywong512@gmail.com/
- Remove redundant '('
---
tools/include/nolibc/types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/include/nolibc/types.h b/tools/include/nolibc/types.h
index b26a5d0c417c..32d0929c633b 100644
--- a/tools/include/nolibc/types.h
+++ b/tools/include/nolibc/types.h
@@ -201,7 +201,7 @@ struct stat {
/* WARNING, it only deals with the 4096 first majors and 256 first minors */
#define makedev(major, minor) ((dev_t)((((major) & 0xfff) << 8) | ((minor) & 0xff)))
#define major(dev) ((unsigned int)(((dev) >> 8) & 0xfff))
-#define minor(dev) ((unsigned int)(((dev) & 0xff))
+#define minor(dev) ((unsigned int)((dev) & 0xff))
#ifndef offsetof
#define offsetof(TYPE, FIELD) ((size_t) &((TYPE *)0)->FIELD)
--
2.43.0
Hi Thomas, I hope this email finds you well. Following your feedback, I submitted v3 of my patch: https://lore.kernel.org/all/20250411073624.22153-1-jemmywong512@gmail.com/ I’m writing to kindly follow up on the status of this submission and check if it’s being processed or if there are any updates. Please let me know if there’s anything I need to address to help move the review process forward. Thank you for your time and guidance. Best regards, Jemmy
Hi Jemmy, On 2025-04-16 21:42:16+0800, Jemmy Wong wrote: > I hope this email finds you well. It does, thanks! I hope this response also finds you well. > Following your feedback, I submitted v3 of my patch: > https://lore.kernel.org/all/20250411073624.22153-1-jemmywong512@gmail.com/ > > I’m writing to kindly follow up on the status of this submission > and check if it’s being processed or if there are any updates. I picked up the patch and it is scheduled to be part of the v6.16 release. https://git.kernel.org/pub/scm/linux/kernel/git/nolibc/linux-nolibc.git/commit/?h=next&id=9c138ac9392228835b520fd4dbb07e636b34a867 > Please let me know if there’s anything I need to address > to help move the review process forward. There is nothing more to do, except wait. > Thank you for your time and guidance. Thanks again for your contribution! Thomas
© 2016 - 2026 Red Hat, Inc.