[v1] gpiolib: Allow to use setters with return value for output-only gpios

[PATCH] gpiolib: Allow to use setters with return value for output-only gpios

Posted by Mathieu Dubois-Briand 10 months ago

The gpiod_direction_output_raw_commit() function checks if any setter
callback is present before doing anything. As the new GPIO setters with
return values were introduced, make this check also succeed if one is
present.

Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index b8197502a5ac..cd4fecbb41f2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2879,7 +2879,7 @@ static int gpiod_direction_output_raw_commit(struct gpio_desc *desc, int value)
 	 * output-only, but if there is then not even a .set() operation it
 	 * is pretty tricky to drive the output line.
 	 */
-	if (!guard.gc->set && !guard.gc->direction_output) {
+	if (!guard.gc->set && !guard.gc->set_rv && !guard.gc->direction_output) {
 		gpiod_warn(desc,
 			   "%s: missing set() and direction_output() operations\n",
 			   __func__);

---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250411-mdb-gpiolib-setters-fix-b87976992070

Best regards,
-- 
Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>

Re: [PATCH] gpiolib: Allow to use setters with return value for output-only gpios

Posted by Bartosz Golaszewski 10 months ago

On Fri, Apr 11, 2025 at 12:31 PM Mathieu Dubois-Briand
<mathieu.dubois-briand@bootlin.com> wrote:
>
> The gpiod_direction_output_raw_commit() function checks if any setter
> callback is present before doing anything. As the new GPIO setters with
> return values were introduced, make this check also succeed if one is
> present.
>
> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> ---
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index b8197502a5ac..cd4fecbb41f2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -2879,7 +2879,7 @@ static int gpiod_direction_output_raw_commit(struct gpio_desc *desc, int value)
>          * output-only, but if there is then not even a .set() operation it
>          * is pretty tricky to drive the output line.
>          */
> -       if (!guard.gc->set && !guard.gc->direction_output) {
> +       if (!guard.gc->set && !guard.gc->set_rv && !guard.gc->direction_output) {
>                 gpiod_warn(desc,
>                            "%s: missing set() and direction_output() operations\n",
>                            __func__);
>
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250411-mdb-gpiolib-setters-fix-b87976992070
>
> Best regards,
> --
> Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>

Ah good catch. Since the culprit is already in mainline, would you
mind resending with Cc: stable and Fixes: tags?

Bart

Re: [PATCH] gpiolib: Allow to use setters with return value for output-only gpios

Posted by Mathieu Dubois-Briand 10 months ago

On Fri Apr 11, 2025 at 1:38 PM CEST, Bartosz Golaszewski wrote:
> On Fri, Apr 11, 2025 at 12:31 PM Mathieu Dubois-Briand
> <mathieu.dubois-briand@bootlin.com> wrote:
>>
>> The gpiod_direction_output_raw_commit() function checks if any setter
>> callback is present before doing anything. As the new GPIO setters with
>> return values were introduced, make this check also succeed if one is
>> present.
>>
>> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>> ---
>>  drivers/gpio/gpiolib.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index b8197502a5ac..cd4fecbb41f2 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -2879,7 +2879,7 @@ static int gpiod_direction_output_raw_commit(struct gpio_desc *desc, int value)
>>          * output-only, but if there is then not even a .set() operation it
>>          * is pretty tricky to drive the output line.
>>          */
>> -       if (!guard.gc->set && !guard.gc->direction_output) {
>> +       if (!guard.gc->set && !guard.gc->set_rv && !guard.gc->direction_output) {
>>                 gpiod_warn(desc,
>>                            "%s: missing set() and direction_output() operations\n",
>>                            __func__);
>>
>> ---
>> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
>> change-id: 20250411-mdb-gpiolib-setters-fix-b87976992070
>>
>> Best regards,
>> --
>> Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
>>
>
> Ah good catch. Since the culprit is already in mainline, would you
> mind resending with Cc: stable and Fixes: tags?
>
> Bart

Thanks, I had a doubt about stable, as I believe this only reached rc1
so far. I will send a new version a bit later today.

Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com