[PATCH -v2 1/2] wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally

Zhen XIN posted 2 patches 10 months ago
[PATCH -v2 1/2] wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally
Posted by Zhen XIN 10 months ago
Rtw88-sdio do not work in AP mode due to the lack of tx status report for
management frames.

Make the invocation of rtw_sdio_indicate_tx_status unconditional and cover
all packet queues

Tested-on: rtl8723ds

Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
---
 drivers/net/wireless/realtek/rtw88/sdio.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
index e024061bdbf7..ef51128a4b44 100644
--- a/drivers/net/wireless/realtek/rtw88/sdio.c
+++ b/drivers/net/wireless/realtek/rtw88/sdio.c
@@ -1227,10 +1227,7 @@ static void rtw_sdio_process_tx_queue(struct rtw_dev *rtwdev,
 		return;
 	}
 
-	if (queue <= RTW_TX_QUEUE_VO)
-		rtw_sdio_indicate_tx_status(rtwdev, skb);
-	else
-		dev_kfree_skb_any(skb);
+	rtw_sdio_indicate_tx_status(rtwdev, skb);
 }
 
 static void rtw_sdio_tx_handler(struct work_struct *work)
-- 
2.25.1
Re: [PATCH -v2 1/2] wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally
Posted by Martin Blumenstingl 10 months ago
On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
>
> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> management frames.
>
> Make the invocation of rtw_sdio_indicate_tx_status unconditional and cover
> all packet queues
>
> Tested-on: rtl8723ds
>
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>