btrfs: Fix the incorrect description in comments.

[PATCH] btrfs: Fix the incorrect description in comments.

Posted by Charles Han 8 months, 1 week ago

Replace PTR_ERR(-ENOMEM) to ERR_PTR(-ENOMEM) in comments.

Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 fs/btrfs/delayed-inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index 3f1551d8a5c6..e35626270f2b 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -119,7 +119,7 @@ static struct btrfs_delayed_node *btrfs_get_delayed_node(
 	return NULL;
 }
 
-/* Will return either the node or PTR_ERR(-ENOMEM) */
+/* Will return either the node or ERR_PTR(-ENOMEM) */
 static struct btrfs_delayed_node *btrfs_get_or_create_delayed_node(
 		struct btrfs_inode *btrfs_inode)
 {
-- 
2.43.0

Re: [PATCH] btrfs: Fix the incorrect description in comments.

Posted by David Sterba 8 months ago

On Thu, Apr 10, 2025 at 05:07:22PM +0800, Charles Han wrote:
> Replace PTR_ERR(-ENOMEM) to ERR_PTR(-ENOMEM) in comments.
> 
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
>  fs/btrfs/delayed-inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> index 3f1551d8a5c6..e35626270f2b 100644
> --- a/fs/btrfs/delayed-inode.c
> +++ b/fs/btrfs/delayed-inode.c
> @@ -119,7 +119,7 @@ static struct btrfs_delayed_node *btrfs_get_delayed_node(
>  	return NULL;
>  }
>  
> -/* Will return either the node or PTR_ERR(-ENOMEM) */
> +/* Will return either the node or ERR_PTR(-ENOMEM) */

Thanks, while this is correct it would be better to update the whole
function comment so it's more descriptive. I'll write someting when
adding the patch to for-next, thanks.