[PATCH 1/2] dt-bindings: rtc: nxp,pcf85063: add 'no-battery' property

Ciprian Costea posted 2 patches 8 months, 1 week ago
[PATCH 1/2] dt-bindings: rtc: nxp,pcf85063: add 'no-battery' property
Posted by Ciprian Costea 8 months, 1 week ago
From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>

In case the RTC is not linked to any battery, the oscillator will
be stopped at startup, triggering a SW reset command for the PCF85063 RTC.
For this setup, introduce 'no-battery' property which can be used to
manually start the oscillator.

Co-developed-by: Larisa Grigore <larisa.grigore@nxp.com>
Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com>
Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
---
 Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
index 2f892f8640d1..b342eb13fb2e 100644
--- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
+++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
@@ -36,6 +36,11 @@ properties:
     enum: [7000, 12500]
     default: 7000
 
+  no-battery:
+    description: Used in case the RTC is not linked to any battery so the
+      oscillator is stopped at startup.
+    type: boolean
+
   clock:
     $ref: /schemas/clock/fixed-clock.yaml
     description:
-- 
2.45.2
Re: [PATCH 1/2] dt-bindings: rtc: nxp,pcf85063: add 'no-battery' property
Posted by Frank Li 8 months, 1 week ago
On Thu, Apr 10, 2025 at 11:25:47AM +0300, Ciprian Costea wrote:
> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>
> In case the RTC is not linked to any battery, the oscillator will
> be stopped at startup, triggering a SW reset command for the PCF85063 RTC.
> For this setup, introduce 'no-battery' property which can be used to
> manually start the oscillator.
>
> Co-developed-by: Larisa Grigore <larisa.grigore@nxp.com>
> Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com>
> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
> ---
>  Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> index 2f892f8640d1..b342eb13fb2e 100644
> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> @@ -36,6 +36,11 @@ properties:
>      enum: [7000, 12500]
>      default: 7000
>
> +  no-battery:
> +    description: Used in case the RTC is not linked to any battery so the
> +      oscillator is stopped at startup.
> +    type: boolean

Can you use optional regulator such as, vbat-supply?

Frank

> +
>    clock:
>      $ref: /schemas/clock/fixed-clock.yaml
>      description:
> --
> 2.45.2
>
Re: [PATCH 1/2] dt-bindings: rtc: nxp,pcf85063: add 'no-battery' property
Posted by Ciprian Marian Costea 8 months, 1 week ago
On 4/10/2025 5:46 PM, Frank Li wrote:
> On Thu, Apr 10, 2025 at 11:25:47AM +0300, Ciprian Costea wrote:
>> From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>>
>> In case the RTC is not linked to any battery, the oscillator will
>> be stopped at startup, triggering a SW reset command for the PCF85063 RTC.
>> For this setup, introduce 'no-battery' property which can be used to
>> manually start the oscillator.
>>
>> Co-developed-by: Larisa Grigore <larisa.grigore@nxp.com>
>> Signed-off-by: Larisa Grigore <larisa.grigore@nxp.com>
>> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
>> ---
>>   Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>> index 2f892f8640d1..b342eb13fb2e 100644
>> --- a/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
>> @@ -36,6 +36,11 @@ properties:
>>       enum: [7000, 12500]
>>       default: 7000
>>
>> +  no-battery:
>> +    description: Used in case the RTC is not linked to any battery so the
>> +      oscillator is stopped at startup.
>> +    type: boolean
> 
> Can you use optional regulator such as, vbat-supply?
> 
> Frank
> 

Hello Frank,

Please disregard this patchset, as stated in the next patch review [1]

[1] 
https://lore.kernel.org/all/e64083ee-3374-4bdf-92a3-ce91e1402b13@oss.nxp.com/

Regards,
Ciprian

>> +
>>     clock:
>>       $ref: /schemas/clock/fixed-clock.yaml
>>       description:
>> --
>> 2.45.2
>>