[v2] Enable jpeg enc & dec multi-hardwares for MT8196

[PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Posted by kyrie.wu 8 months, 1 week ago

Add mediatek,mt8196-jpgdec compatible to binding document.

Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
---
 .../bindings/media/mediatek,mt8195-jpegdec.yaml           | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
index e5448c60e3eb..28a9a9bfdbf8 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
@@ -14,7 +14,9 @@ description:
 
 properties:
   compatible:
-    const: mediatek,mt8195-jpgdec
+    enum:
+      - mediatek,mt8195-jpgdec
+      - mediatek,mt8196-jpgdec
 
   power-domains:
     maxItems: 1
@@ -44,7 +46,9 @@ patternProperties:
 
     properties:
       compatible:
-        const: mediatek,mt8195-jpgdec-hw
+        enum:
+          - mediatek,mt8195-jpgdec-hw
+          - mediatek,mt8196-jpgdec-hw
 
       reg:
         maxItems: 1
-- 
2.46.0

Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Posted by Krzysztof Kozlowski 8 months, 1 week ago

On Thu, Apr 10, 2025 at 02:29:54PM GMT, kyrie.wu wrote:
> Add mediatek,mt8196-jpgdec compatible to binding document.
> 
> Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>

Usual mediatek comment - looks like copy paste of username. Please reach
to your colleagues how to fix it.

> ---
>  .../bindings/media/mediatek,mt8195-jpegdec.yaml           | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> index e5448c60e3eb..28a9a9bfdbf8 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegdec.yaml
> @@ -14,7 +14,9 @@ description:
>  
>  properties:
>    compatible:
> -    const: mediatek,mt8195-jpgdec
> +    enum:
> +      - mediatek,mt8195-jpgdec
> +      - mediatek,mt8196-jpgdec

And devices are not compatible?

Best regards,
Krzysztof

Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Posted by Kyrie Wu (吴晗) 8 months, 1 week ago

On Thu, 2025-04-10 at 08:39 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Thu, Apr 10, 2025 at 02:29:54PM GMT, kyrie.wu wrote:
> > Add mediatek,mt8196-jpgdec compatible to binding document.
> > 
> > Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
> 
> Usual mediatek comment - looks like copy paste of username. Please
> reach
> to your colleagues how to fix it.

Dear Krzysztof,

Do I need to change the username like that: Kyrie Wu <
kyrie.wu@mediatek.com>?

Thanks.
> 
> > ---
> >  .../bindings/media/mediatek,mt8195-jpegdec.yaml           | 8
> > ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > index e5448c60e3eb..28a9a9bfdbf8 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > jpegdec.yaml
> > @@ -14,7 +14,9 @@ description:
> > 
> >  properties:
> >    compatible:
> > -    const: mediatek,mt8195-jpgdec
> > +    enum:
> > +      - mediatek,mt8195-jpgdec
> > +      - mediatek,mt8196-jpgdec
> 
> And devices are not compatible?

Sorry, I don't understand the question exactly. Do you mean using the
compatible string of MT8195 for both MT8195 and MT8196?

Thanks.
> 
> Best regards,
> Krzysztof
> 

Regards,
Kyrie

Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Posted by Krzysztof Kozlowski 8 months, 1 week ago

On 11/04/2025 04:54, Kyrie Wu (吴晗) wrote:
> On Thu, 2025-04-10 at 08:39 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Thu, Apr 10, 2025 at 02:29:54PM GMT, kyrie.wu wrote:
>>> Add mediatek,mt8196-jpgdec compatible to binding document.
>>>
>>> Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
>>
>> Usual mediatek comment - looks like copy paste of username. Please
>> reach
>> to your colleagues how to fix it.
> 
> Dear Krzysztof,
> 
> Do I need to change the username like that: Kyrie Wu <
> kyrie.wu@mediatek.com>?

And what did your colleagues say? Please use Mediatek resources prior
asking community for review.

> 
> Thanks.
>>
>>> ---
>>>  .../bindings/media/mediatek,mt8195-jpegdec.yaml           | 8
>>> ++++++--
>>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> b/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> index e5448c60e3eb..28a9a9bfdbf8 100644
>>> --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> @@ -14,7 +14,9 @@ description:
>>>
>>>  properties:
>>>    compatible:
>>> -    const: mediatek,mt8195-jpgdec
>>> +    enum:
>>> +      - mediatek,mt8195-jpgdec
>>> +      - mediatek,mt8196-jpgdec
>>
>> And devices are not compatible?
> 
> Sorry, I don't understand the question exactly. Do you mean using the
> compatible string of MT8195 for both MT8195 and MT8196?

No, expressing compatibility with fallbacks or explaining in commit msg
the hardware, e.g. why these are not compatible.


Best regards,
Krzysztof

Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Posted by Kyrie Wu (吴晗) 8 months, 1 week ago

On Sat, 2025-04-12 at 12:13 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 11/04/2025 04:54, Kyrie Wu (吴晗) wrote:
> > On Thu, 2025-04-10 at 08:39 +0200, Krzysztof Kozlowski wrote:
> > > External email : Please do not click links or open attachments
> > > until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > On Thu, Apr 10, 2025 at 02:29:54PM GMT, kyrie.wu wrote:
> > > > Add mediatek,mt8196-jpgdec compatible to binding document.
> > > > 
> > > > Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
> > > 
> > > Usual mediatek comment - looks like copy paste of username.
> > > Please
> > > reach
> > > to your colleagues how to fix it.
> > 
> > Dear Krzysztof,
> > 
> > Do I need to change the username like that: Kyrie Wu <
> > kyrie.wu@mediatek.com>?
> 
> And what did your colleagues say? Please use Mediatek resources prior
> asking community for review.

Dear Krzysztof,

The above username is suggested by my colleagues. I queried with you to
avoid made this mistake again.

Thanks.
> 
> > 
> > Thanks.
> > > 
> > > > ---
> > > >  .../bindings/media/mediatek,mt8195-jpegdec.yaml           | 8
> > > > ++++++--
> > > >  1 file changed, 6 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > > jpegdec.yaml
> > > > b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > > jpegdec.yaml
> > > > index e5448c60e3eb..28a9a9bfdbf8 100644
> > > > --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > > jpegdec.yaml
> > > > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
> > > > jpegdec.yaml
> > > > @@ -14,7 +14,9 @@ description:
> > > > 
> > > >  properties:
> > > >    compatible:
> > > > -    const: mediatek,mt8195-jpgdec
> > > > +    enum:
> > > > +      - mediatek,mt8195-jpgdec
> > > > +      - mediatek,mt8196-jpgdec
> > > 
> > > And devices are not compatible?
> > 
> > Sorry, I don't understand the question exactly. Do you mean using
> > the
> > compatible string of MT8195 for both MT8195 and MT8196?
> 
> No, expressing compatibility with fallbacks or explaining in commit
> msg
> the hardware, e.g. why these are not compatible.

Thanks.
I will fix the commit message. There are several differeances between
the two chips. e.g. 8195 uses iommu but smmu is used in 8196. And 8196
will support dynamic voltage and frequency scale.
> 
> 
> Best regards,
> Krzysztof


Regards,
Kyrie.