[PATCH RFC] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()

Zijun Hu posted 1 patch 10 months ago
fs/fs_context.c | 4 ++++
1 file changed, 4 insertions(+)
[PATCH RFC] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()
Posted by Zijun Hu 10 months ago
From: Zijun Hu <quic_zijuhu@quicinc.com>

Use KERN_INFO instead of default KERN_NOTICE for
infof()|info_plog()|infofc() to printk informational messages.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 fs/fs_context.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/fs_context.c b/fs/fs_context.c
index 582d33e8111739402d38dc9fc268e7d14ced3c49..2877d9dec0753a5f03e0a54fa7b8d25072ea7b4d 100644
--- a/fs/fs_context.c
+++ b/fs/fs_context.c
@@ -449,6 +449,10 @@ void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt,
 			printk(KERN_ERR "%s%s%pV\n", prefix ? prefix : "",
 						prefix ? ": " : "", &vaf);
 			break;
+		case 'i':
+			printk(KERN_INFO "%s%s%pV\n", prefix ? prefix : "",
+						prefix ? ": " : "", &vaf);
+			break;
 		default:
 			printk(KERN_NOTICE "%s%s%pV\n", prefix ? prefix : "",
 						prefix ? ": " : "", &vaf);

---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250410-rfc_fix_fs-cfa369930abe

Best regards,
-- 
Zijun Hu <quic_zijuhu@quicinc.com>
Re: [PATCH RFC] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()
Posted by Christian Brauner 10 months ago
On Thu, 10 Apr 2025 19:53:03 +0800, Zijun Hu wrote:
> Use KERN_INFO instead of default KERN_NOTICE for
> infof()|info_plog()|infofc() to printk informational messages.
> 
> 

Applied to the vfs-6.16.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.16.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.16.misc

[1/1] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()
      https://git.kernel.org/vfs/vfs/c/916148d24d77
Re: [PATCH RFC] fs/fs_context: Use KERN_INFO for infof()|info_plog()|infofc()
Posted by Christian Brauner 10 months ago
On Thu, Apr 10, 2025 at 07:53:03PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@quicinc.com>
> 
> Use KERN_INFO instead of default KERN_NOTICE for
> infof()|info_plog()|infofc() to printk informational messages.
> 
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> ---
>  fs/fs_context.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/fs_context.c b/fs/fs_context.c
> index 582d33e8111739402d38dc9fc268e7d14ced3c49..2877d9dec0753a5f03e0a54fa7b8d25072ea7b4d 100644
> --- a/fs/fs_context.c
> +++ b/fs/fs_context.c
> @@ -449,6 +449,10 @@ void logfc(struct fc_log *log, const char *prefix, char level, const char *fmt,
>  			printk(KERN_ERR "%s%s%pV\n", prefix ? prefix : "",
>  						prefix ? ": " : "", &vaf);
>  			break;
> +		case 'i':
> +			printk(KERN_INFO "%s%s%pV\n", prefix ? prefix : "",
> +						prefix ? ": " : "", &vaf);

We can try but it's not out of the question that this might cause users
to complain or cause regressions.

> +			break;
>  		default:
>  			printk(KERN_NOTICE "%s%s%pV\n", prefix ? prefix : "",
>  						prefix ? ": " : "", &vaf);
> 
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250410-rfc_fix_fs-cfa369930abe
> 
> Best regards,
> -- 
> Zijun Hu <quic_zijuhu@quicinc.com>
>