[PATCH v1 0/2] gpiolib: acpi: Fix missing info filling

Andy Shevchenko posted 2 patches 4 weeks ago
drivers/gpio/gpiolib-acpi.c | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
[PATCH v1 0/2] gpiolib: acpi: Fix missing info filling
Posted by Andy Shevchenko 4 weeks ago
Kees reported that code, while being refactored, missed the point of
filling the info structure which supplies GPIO flags to the upper layer.
Indeed, without that part the GPIO expander get no IRQ on Intel Edison,
for example. Fix this in this series.

Andy Shevchenko (2):
  gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
  gpiolib: acpi: Make sure we fill struct acpi_gpio_info

 drivers/gpio/gpiolib-acpi.c | 36 ++++++++++++++++++++----------------
 1 file changed, 20 insertions(+), 16 deletions(-)

-- 
2.47.2
Re: [PATCH v1 0/2] gpiolib: acpi: Fix missing info filling
Posted by Mika Westerberg 4 weeks ago
On Wed, Apr 09, 2025 at 04:27:52PM +0300, Andy Shevchenko wrote:
> Kees reported that code, while being refactored, missed the point of
> filling the info structure which supplies GPIO flags to the upper layer.
> Indeed, without that part the GPIO expander get no IRQ on Intel Edison,
> for example. Fix this in this series.
> 
> Andy Shevchenko (2):
>   gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
>   gpiolib: acpi: Make sure we fill struct acpi_gpio_info

Both,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Re: [PATCH v1 0/2] gpiolib: acpi: Fix missing info filling
Posted by Andy Shevchenko 4 weeks ago
On Wed, Apr 09, 2025 at 04:44:43PM +0300, Mika Westerberg wrote:
> On Wed, Apr 09, 2025 at 04:27:52PM +0300, Andy Shevchenko wrote:
> > Kees reported that code, while being refactored, missed the point of
> > filling the info structure which supplies GPIO flags to the upper layer.
> > Indeed, without that part the GPIO expander get no IRQ on Intel Edison,
> > for example. Fix this in this series.
> > 
> > Andy Shevchenko (2):
> >   gpiolib: acpi: Use temporary variable for struct acpi_gpio_info
> >   gpiolib: acpi: Make sure we fill struct acpi_gpio_info
> 
> Both,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko