1. Patchew
  2. linux
  3. View series

[PATCH] MAINTAINERS: add memory advice section

Lorenzo Stoakes posted 1 patch 8 months, 1 week ago
There is a newer version of this series
MAINTAINERS | 13 +++++++++++++
1 file changed, 13 insertions(+)
[PATCH] MAINTAINERS: add memory advice section
Posted by Lorenzo Stoakes 8 months, 1 week ago 
The madvise code straddles both VMA and page table manipulation. As a
result, separate it out into its own section and add maintainers/reviewers
as appropriate.

We additionally include the mman-common.h file as this contains the shared
madvise flags and it is important we maintain this alongside madvise.c.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
 MAINTAINERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index de97cd54ff24..325424a53acf 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15552,6 +15552,19 @@ F:	mm/vma.h
 F:	mm/vma_internal.h
 F:	tools/testing/vma/
 
+MEMORY MAPPING - MEMORY ADVICE
+M:	Andrew Morton <akpm@linux-foundation.org>
+M:	Liam R. Howlett <Liam.Howlett@oracle.com>
+M:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
+M:	David Hildenbrand <david@redhat.com>
+R:	Vlastimil Babka <vbabka@suse.cz>
+R:	Jann Horn <jannh@google.com>
+S:	Maintained
+W:	http://www.linux-mm.org
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
+F:	include/uapi/asm-generic/mman-common.h
+F:	mm/madvise.c
+
 MEMORY TECHNOLOGY DEVICES (MTD)
 M:	Miquel Raynal <miquel.raynal@bootlin.com>
 M:	Richard Weinberger <richard@nod.at>
-- 
2.49.0
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Jann Horn 8 months, 1 week ago 
On Tue, Apr 8, 2025 at 6:11 PM Lorenzo Stoakes
<lorenzo.stoakes@oracle.com> wrote:
> The madvise code straddles both VMA and page table manipulation. As a
> result, separate it out into its own section and add maintainers/reviewers
> as appropriate.
>
> We additionally include the mman-common.h file as this contains the shared
> madvise flags and it is important we maintain this alongside madvise.c.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Acked-by: Jann Horn <jannh@google.com>

> +MEMORY MAPPING - MEMORY ADVICE
> +M:     Andrew Morton <akpm@linux-foundation.org>
> +M:     Liam R. Howlett <Liam.Howlett@oracle.com>
> +M:     Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +M:     David Hildenbrand <david@redhat.com>
> +R:     Vlastimil Babka <vbabka@suse.cz>
> +R:     Jann Horn <jannh@google.com>
> +S:     Maintained
> +W:     http://www.linux-mm.org
> +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:     include/uapi/asm-generic/mman-common.h
> +F:     mm/madvise.c

Is it intentional that this one, unlike "MEMORY MAPPING", has no
explicit "L: linux-mm@kvack.org" and relies on the inheritance from
the overall "MEMORY MANAGEMENT" entry for that?
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Lorenzo Stoakes 8 months, 1 week ago 
On Tue, Apr 08, 2025 at 08:56:30PM +0200, Jann Horn wrote:
> On Tue, Apr 8, 2025 at 6:11 PM Lorenzo Stoakes
> <lorenzo.stoakes@oracle.com> wrote:
> > The madvise code straddles both VMA and page table manipulation. As a
> > result, separate it out into its own section and add maintainers/reviewers
> > as appropriate.
> >
> > We additionally include the mman-common.h file as this contains the shared
> > madvise flags and it is important we maintain this alongside madvise.c.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> Acked-by: Jann Horn <jannh@google.com>

Thanks!

>
> > +MEMORY MAPPING - MEMORY ADVICE
> > +M:     Andrew Morton <akpm@linux-foundation.org>
> > +M:     Liam R. Howlett <Liam.Howlett@oracle.com>
> > +M:     Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > +M:     David Hildenbrand <david@redhat.com>
> > +R:     Vlastimil Babka <vbabka@suse.cz>
> > +R:     Jann Horn <jannh@google.com>
> > +S:     Maintained
> > +W:     http://www.linux-mm.org
> > +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:     include/uapi/asm-generic/mman-common.h
> > +F:     mm/madvise.c
>
> Is it intentional that this one, unlike "MEMORY MAPPING", has no
> explicit "L: linux-mm@kvack.org" and relies on the inheritance from
> the overall "MEMORY MANAGEMENT" entry for that?

No, was a mistake, have asked Andrew to fix in a fixpatch! Good
spot... whoops!
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by David Hildenbrand 8 months, 1 week ago 
On 08.04.25 18:11, Lorenzo Stoakes wrote:
> The madvise code straddles both VMA and page table manipulation. As a
> result, separate it out into its own section and add maintainers/reviewers
> as appropriate.
> 
> We additionally include the mman-common.h file as this contains the shared
> madvise flags and it is important we maintain this alongside madvise.c.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
>   MAINTAINERS | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index de97cd54ff24..325424a53acf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15552,6 +15552,19 @@ F:	mm/vma.h
>   F:	mm/vma_internal.h
>   F:	tools/testing/vma/
>   
> +MEMORY MAPPING - MEMORY ADVICE
> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +M:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Vlastimil Babka <vbabka@suse.cz>
> +R:	Jann Horn <jannh@google.com>
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/uapi/asm-generic/mman-common.h
> +F:	mm/madvise.c
> +
>   MEMORY TECHNOLOGY DEVICES (MTD)
>   M:	Miquel Raynal <miquel.raynal@bootlin.com>
>   M:	Richard Weinberger <richard@nod.at>

Thanks!

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Liam R. Howlett 8 months, 1 week ago 
* Lorenzo Stoakes <lorenzo.stoakes@oracle.com> [250408 12:11]:
> The madvise code straddles both VMA and page table manipulation. As a
> result, separate it out into its own section and add maintainers/reviewers
> as appropriate.
> 
> We additionally include the mman-common.h file as this contains the shared
> madvise flags and it is important we maintain this alongside madvise.c.
> 
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

Acked-by: Liam R. Howlett <Liam.Howlett@oracle.com>

> ---
>  MAINTAINERS | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index de97cd54ff24..325424a53acf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15552,6 +15552,19 @@ F:	mm/vma.h
>  F:	mm/vma_internal.h
>  F:	tools/testing/vma/
>  
> +MEMORY MAPPING - MEMORY ADVICE

Advice or advise?

> +M:	Andrew Morton <akpm@linux-foundation.org>
> +M:	Liam R. Howlett <Liam.Howlett@oracle.com>
> +M:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> +M:	David Hildenbrand <david@redhat.com>
> +R:	Vlastimil Babka <vbabka@suse.cz>
> +R:	Jann Horn <jannh@google.com>
> +S:	Maintained
> +W:	http://www.linux-mm.org
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> +F:	include/uapi/asm-generic/mman-common.h
> +F:	mm/madvise.c
> +
>  MEMORY TECHNOLOGY DEVICES (MTD)
>  M:	Miquel Raynal <miquel.raynal@bootlin.com>
>  M:	Richard Weinberger <richard@nod.at>
> -- 
> 2.49.0
>
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Lorenzo Stoakes 8 months, 1 week ago 
On Tue, Apr 08, 2025 at 01:00:41PM -0400, Liam R. Howlett wrote:
> * Lorenzo Stoakes <lorenzo.stoakes@oracle.com> [250408 12:11]:
> > The madvise code straddles both VMA and page table manipulation. As a
> > result, separate it out into its own section and add maintainers/reviewers
> > as appropriate.
> >
> > We additionally include the mman-common.h file as this contains the shared
> > madvise flags and it is important we maintain this alongside madvise.c.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> Acked-by: Liam R. Howlett <Liam.Howlett@oracle.com>

Thanks!

>
> > ---
> >  MAINTAINERS | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index de97cd54ff24..325424a53acf 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -15552,6 +15552,19 @@ F:	mm/vma.h
> >  F:	mm/vma_internal.h
> >  F:	tools/testing/vma/
> >
> > +MEMORY MAPPING - MEMORY ADVICE
>
> Advice or advise?

I mean we give advice on memory right? ;)

I think Andrew's suggestion of madvise (memory advice) should cover
everything off. I adjust felt icky at the grammar of saying madvise here
but that idea fixes that.

>
> > +M:	Andrew Morton <akpm@linux-foundation.org>
> > +M:	Liam R. Howlett <Liam.Howlett@oracle.com>
> > +M:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > +M:	David Hildenbrand <david@redhat.com>
> > +R:	Vlastimil Babka <vbabka@suse.cz>
> > +R:	Jann Horn <jannh@google.com>
> > +S:	Maintained
> > +W:	http://www.linux-mm.org
> > +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > +F:	include/uapi/asm-generic/mman-common.h
> > +F:	mm/madvise.c
> > +
> >  MEMORY TECHNOLOGY DEVICES (MTD)
> >  M:	Miquel Raynal <miquel.raynal@bootlin.com>
> >  M:	Richard Weinberger <richard@nod.at>
> > --
> > 2.49.0
> >
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Andrew Morton 8 months, 1 week ago 
On Tue, 8 Apr 2025 13:00:41 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:

> > +MEMORY MAPPING - MEMORY ADVICE
> 
> Advice or advise?

"madvise" is what people will search for.  Perhaps

	MEMORY MAPPING - MADVISE (MEMORY ADVICE)
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Lorenzo Stoakes 8 months, 1 week ago 
On Tue, Apr 08, 2025 at 02:19:18PM -0700, Andrew Morton wrote:
> On Tue, 8 Apr 2025 13:00:41 -0400 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
>
> > > +MEMORY MAPPING - MEMORY ADVICE
> >
> > Advice or advise?
>
> "madvise" is what people will search for.  Perhaps
>
> 	MEMORY MAPPING - MADVISE (MEMORY ADVICE)
>

Yeah, this seems better, also as Jann pointed out I missed off the L line
by mistake, can you apply the following fix-patch? Thanks!

----8<----
From cc37203d68dc9bae87e313fed9590aa3f63793c1 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Date: Wed, 9 Apr 2025 06:16:16 +0100
Subject: [PATCH] fixup

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 325424a53acf..526ecbbbb560 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15552,13 +15552,14 @@ F:	mm/vma.h
 F:	mm/vma_internal.h
 F:	tools/testing/vma/

-MEMORY MAPPING - MEMORY ADVICE
+MEMORY MAPPING - MADVISE (MEMORY ADVICE)
 M:	Andrew Morton <akpm@linux-foundation.org>
 M:	Liam R. Howlett <Liam.Howlett@oracle.com>
 M:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
 M:	David Hildenbrand <david@redhat.com>
 R:	Vlastimil Babka <vbabka@suse.cz>
 R:	Jann Horn <jannh@google.com>
+L:	linux-mm@kvack.org
 S:	Maintained
 W:	http://www.linux-mm.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
--
2.49.0
Re: [PATCH] MAINTAINERS: add memory advice section
Posted by Vlastimil Babka 8 months, 1 week ago 
On 4/8/25 19:00, Liam R. Howlett wrote:
> * Lorenzo Stoakes <lorenzo.stoakes@oracle.com> [250408 12:11]:
>> The madvise code straddles both VMA and page table manipulation. As a
>> result, separate it out into its own section and add maintainers/reviewers
>> as appropriate.
>> 
>> We additionally include the mman-common.h file as this contains the shared
>> madvise flags and it is important we maintain this alongside madvise.c.
>> 
>> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> 
> Acked-by: Liam R. Howlett <Liam.Howlett@oracle.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> 
>> ---
>>  MAINTAINERS | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index de97cd54ff24..325424a53acf 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -15552,6 +15552,19 @@ F:	mm/vma.h
>>  F:	mm/vma_internal.h
>>  F:	tools/testing/vma/
>>  
>> +MEMORY MAPPING - MEMORY ADVICE
> 
> Advice or advise?

For me "MADVISE" would be the most obvious but I don't really mind either way.

>> +M:	Andrew Morton <akpm@linux-foundation.org>
>> +M:	Liam R. Howlett <Liam.Howlett@oracle.com>
>> +M:	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>> +M:	David Hildenbrand <david@redhat.com>
>> +R:	Vlastimil Babka <vbabka@suse.cz>
>> +R:	Jann Horn <jannh@google.com>
>> +S:	Maintained
>> +W:	http://www.linux-mm.org
>> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>> +F:	include/uapi/asm-generic/mman-common.h
>> +F:	mm/madvise.c
>> +
>>  MEMORY TECHNOLOGY DEVICES (MTD)
>>  M:	Miquel Raynal <miquel.raynal@bootlin.com>
>>  M:	Richard Weinberger <richard@nod.at>
>> -- 
>> 2.49.0
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.