[PATCH v2 1/4] media: dt-bindings: Document Tegra186 and Tegra194 cec

Aaron Kling via B4 Relay posted 4 patches 10 months ago
There is a newer version of this series
[PATCH v2 1/4] media: dt-bindings: Document Tegra186 and Tegra194 cec
Posted by Aaron Kling via B4 Relay 10 months ago
From: Aaron Kling <webgeek1234@gmail.com>

These are already used in device trees, so describe them here. As the
driver only declares up through Tegra210, these must use a fallback
compatible of tegra210-cec.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 .../bindings/media/cec/nvidia,tegra114-cec.yaml           | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
index a6b73498bc217a2e884e31af91e9d8845c9b1d76..20d8eb975c2bf67acd407a4683a698b2bfb7c5f8 100644
--- a/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
+++ b/Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml
@@ -14,10 +14,17 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - nvidia,tegra114-cec
-      - nvidia,tegra124-cec
-      - nvidia,tegra210-cec
+    oneOf:
+      - items:
+        - enum:
+          - nvidia,tegra114-cec
+          - nvidia,tegra124-cec
+          - nvidia,tegra210-cec
+      - items:
+        - enum:
+          - nvidia,tegra186-cec
+          - nvidia,tegra194-cec
+        - const: nvidia,tegra210-cec
 
   clocks:
     maxItems: 1

-- 
2.48.1
Re: [PATCH v2 1/4] media: dt-bindings: Document Tegra186 and Tegra194 cec
Posted by Rob Herring (Arm) 10 months ago
On Tue, 08 Apr 2025 15:29:58 -0500, Aaron Kling wrote:
> These are already used in device trees, so describe them here. As the
> driver only declares up through Tegra210, these must use a fallback
> compatible of tegra210-cec.
> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  .../bindings/media/cec/nvidia,tegra114-cec.yaml           | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml:20:11: [warning] wrong indentation: expected 12 but found 10 (indentation)
./Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml:24:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/media/cec/nvidia,tegra114-cec.yaml:25:11: [warning] wrong indentation: expected 12 but found 10 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250408-tegra-cec-v2-1-2f004fdf84e8@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.