Hi Frank,
Thank you for the patch.
On Tue, Apr 08, 2025 at 05:53:04PM -0400, Frank Li wrote:
> Use dev_err_probe() simplify code. No functional changes intended.
In the subject line and here, s/simplify/to simplify/
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> index 073ea5912de3b..398cc03443be3 100644
> --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c
> @@ -428,19 +428,14 @@ static int mxc_isi_probe(struct platform_device *pdev)
> return dev_err_probe(dev, isi->num_clks, "Failed to get clocks\n");
>
> isi->regs = devm_platform_ioremap_resource(pdev, 0);
> - if (IS_ERR(isi->regs)) {
> - dev_err(dev, "Failed to get ISI register map\n");
> - return PTR_ERR(isi->regs);
> - }
> + if (IS_ERR(isi->regs))
> + return dev_err_probe(dev, PTR_ERR(isi->regs), "Failed to get ISI register map\n");
return dev_err_probe(dev, PTR_ERR(isi->regs),
"Failed to get ISI register map\n");
>
> if (isi->pdata->gasket_ops) {
> isi->gasket = syscon_regmap_lookup_by_phandle(dev->of_node,
> "fsl,blk-ctrl");
> - if (IS_ERR(isi->gasket)) {
> - ret = PTR_ERR(isi->gasket);
> - dev_err(dev, "failed to get gasket: %d\n", ret);
> - return ret;
> - }
> + if (IS_ERR(isi->gasket))
> + return dev_err_probe(dev, PTR_ERR(isi->gasket), "failed to get gasket\n");
return dev_err_probe(dev, PTR_ERR(isi->gasket),
"failed to get gasket\n");
With that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> }
>
> dma_size = isi->pdata->has_36bit_dma ? 36 : 32;
--
Regards,
Laurent Pinchart