[PATCH 13/16] i2c: busses: at91: Add MCHP_LAN966X_PCI dependency

Herve Codina posted 16 patches 10 months, 1 week ago
There is a newer version of this series
[PATCH 13/16] i2c: busses: at91: Add MCHP_LAN966X_PCI dependency
Posted by Herve Codina 10 months, 1 week ago
The AT91 I2C driver depends on ARCH_AT91.

This I2C controller can be used by the LAN966x PCI device and so
it needs to be available when the LAN966x PCI device is enabled.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
---
 drivers/i2c/busses/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 83c88c79afe2..148f9f66d5f3 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -414,7 +414,7 @@ config I2C_ASPEED
 
 config I2C_AT91
 	tristate "Atmel AT91 I2C Two-Wire interface (TWI)"
-	depends on ARCH_AT91 || COMPILE_TEST
+	depends on ARCH_AT91 || MCHP_LAN966X_PCI || COMPILE_TEST
 	help
 	  This supports the use of the I2C interface on Atmel AT91
 	  processors.
-- 
2.49.0
Re: [PATCH 13/16] i2c: busses: at91: Add MCHP_LAN966X_PCI dependency
Posted by Andy Shevchenko 10 months, 1 week ago
On Mon, Apr 07, 2025 at 04:55:42PM +0200, Herve Codina wrote:
> The AT91 I2C driver depends on ARCH_AT91.
> 
> This I2C controller can be used by the LAN966x PCI device and so
> it needs to be available when the LAN966x PCI device is enabled.

...

>  config I2C_AT91
>  	tristate "Atmel AT91 I2C Two-Wire interface (TWI)"
> -	depends on ARCH_AT91 || COMPILE_TEST
> +	depends on ARCH_AT91 || MCHP_LAN966X_PCI || COMPILE_TEST

I would drop it altogether in similar way as suggested for the clock driver.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH 13/16] i2c: busses: at91: Add MCHP_LAN966X_PCI dependency
Posted by Herve Codina 10 months ago
Hi Andy,

On Mon, 7 Apr 2025 18:42:55 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Apr 07, 2025 at 04:55:42PM +0200, Herve Codina wrote:
> > The AT91 I2C driver depends on ARCH_AT91.
> > 
> > This I2C controller can be used by the LAN966x PCI device and so
> > it needs to be available when the LAN966x PCI device is enabled.  
> 
> ...
> 
> >  config I2C_AT91
> >  	tristate "Atmel AT91 I2C Two-Wire interface (TWI)"
> > -	depends on ARCH_AT91 || COMPILE_TEST
> > +	depends on ARCH_AT91 || MCHP_LAN966X_PCI || COMPILE_TEST  
> 
> I would drop it altogether in similar way as suggested for the clock driver.
> 

IMHO, they should be kept for the reason mentionned for the clock driver.

Best regards,
Hervé