[PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register

Charles Han posted 1 patch 10 months ago
drivers/clk/davinci/psc.c | 5 +++++
1 file changed, 5 insertions(+)
[PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
Posted by Charles Han 10 months ago
devm_kasprintf() can return a NULL pointer on failure,but this
returned value in davinci_lpsc_clk_register() is not checked.
Add NULL check in davinci_lpsc_clk_register(), to handle kernel
NULL pointer dereference error.

Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
---
 drivers/clk/davinci/psc.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c
index b48322176c21..872fed50dece 100644
--- a/drivers/clk/davinci/psc.c
+++ b/drivers/clk/davinci/psc.c
@@ -277,6 +277,11 @@ davinci_lpsc_clk_register(struct device *dev, const char *name,
 
 	lpsc->pm_domain.name = devm_kasprintf(dev, GFP_KERNEL, "%s: %s",
 					      best_dev_name(dev), name);
+	if (!lpsc->pm_domain.name) {
+		kfree(lpsc);
+		return ERR_PTR(-ENOMEM);
+	}
+
 	lpsc->pm_domain.attach_dev = davinci_psc_genpd_attach_dev;
 	lpsc->pm_domain.detach_dev = davinci_psc_genpd_detach_dev;
 	lpsc->pm_domain.flags = GENPD_FLAG_PM_CLK;
-- 
2.43.0
Re: [PATCH] clk: davinci: Add NULL check in davinci_lpsc_clk_register
Posted by David Lechner 10 months ago
On 4/7/25 4:20 AM, Charles Han wrote:
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in davinci_lpsc_clk_register() is not checked.
> Add NULL check in davinci_lpsc_clk_register(), to handle kernel
> NULL pointer dereference error.
> 
> Fixes: c6ed4d734bc7 ("clk: davinci: New driver for davinci PSC clocks")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>
> ---
Thanks, but this looks like a duplicate of [1].

[1]: https://lore.kernel.org/linux-clk/20250401131341.26800-1-bsdhenrymartin@gmail.com/