staging: gpib: fmh_gpib: Remove unnecessary print function dev_err()

[PATCH] staging: gpib: fmh_gpib: Remove unnecessary print function dev_err()

Posted by Chen Ni 10 months, 1 week ago

Function dev_err() is redundant because platform_get_irq()
already prints an error.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
index 53f4b3fccc3c..5f64f3d989ef 100644
--- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
+++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
@@ -1424,10 +1424,8 @@ static int fmh_gpib_attach_impl(struct gpib_board *board, const gpib_board_confi
 		(unsigned long)resource_size(e_priv->dma_port_res));
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(board->dev, "request for IRQ failed\n");
+	if (irq < 0)
 		return -EBUSY;
-	}
 	retval = request_irq(irq, fmh_gpib_interrupt, IRQF_SHARED, pdev->name, board);
 	if (retval) {
 		dev_err(board->dev,
-- 
2.25.1

Re: [PATCH] staging: gpib: fmh_gpib: Remove unnecessary print function dev_err()

Posted by Dominik Karol Piątkowski 10 months ago

On Monday, April 7th, 2025 at 05:11, Chen Ni <nichen@iscas.ac.cn> wrote:

> 
> 
> Function dev_err() is redundant because platform_get_irq()
> already prints an error.
> 
> Signed-off-by: Chen Ni nichen@iscas.ac.cn
> 
> ---
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
> index 53f4b3fccc3c..5f64f3d989ef 100644
> --- a/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
> +++ b/drivers/staging/gpib/fmh_gpib/fmh_gpib.c
> @@ -1424,10 +1424,8 @@ static int fmh_gpib_attach_impl(struct gpib_board *board, const gpib_board_confi
> (unsigned long)resource_size(e_priv->dma_port_res));
> 
> 
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(board->dev, "request for IRQ failed\n");
> 
> + if (irq < 0)
> return -EBUSY;
> - }
> retval = request_irq(irq, fmh_gpib_interrupt, IRQF_SHARED, pdev->name, board);
> 
> if (retval) {
> dev_err(board->dev,
> 
> --
> 2.25.1

LGTM,
Reviewed-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>