.../memory-controllers/st,stm32mp25-omm.yaml | 226 ++++++++++ MAINTAINERS | 6 + arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 51 +++ arch/arm64/boot/dts/st/stm32mp251.dtsi | 54 +++ arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 32 ++ arch/arm64/configs/defconfig | 2 + drivers/memory/Kconfig | 17 + drivers/memory/Makefile | 1 + drivers/memory/stm32_omm.c | 474 +++++++++++++++++++++ 9 files changed, 863 insertions(+)
This series adds SPI NOR support for STM32MP25 SoCs from STMicroelectronics.
On STM32MP25 SoCs family, an Octo Memory Manager block manages the muxing,
the memory area split, the chip select override and the time constraint
between its 2 Octo SPI children.
Due to these depedencies, this series adds support for:
- Octo Memory Manager driver.
- Octo SPI driver.
- yaml schema for Octo Memory Manager and Octo SPI drivers.
The device tree files adds Octo Memory Manager and its 2 associated Octo
SPI chidren in stm32mp251.dtsi and adds SPI NOR support in stm32mp257f-ev1
board.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
Changes in v8:
- update OMM's dt-bindings:
- Remove minItems for clocks and resets properties.
- Fix st,syscfg-amcr items declaration.
- move power-domains property before vendor specific properties.
- Update compatible check wrongly introduced during internal tests in
stm32_omm.c.
- Move ommanager's node outside bus@42080000's node in stm32mp251.dtsi.
- Link to v7: https://lore.kernel.org/r/20250401-upstream_ospi_v6-v7-0-0ef28513ed81@foss.st.com
Changes in v7:
- update OMM's dt-bindings by updating :
- clock-names and reset-names properties.
- spi unit-address node.
- example.
- update stm32mp251.dtsi to match with OMM's bindings update.
- update stm32mp257f-ev1.dts to match with OMM's bindings update.
- Link to v6: https://lore.kernel.org/r/20250321-upstream_ospi_v6-v6-0-37bbcab43439@foss.st.com
Changes in v6:
- Update MAINTAINERS file.
- Remove previous patch 1/8 and 2/8, merged by Mark Brown in spi git tree.
- Fix Signed-off-by order for patch 3.
- OMM driver:
- Add dev_err_probe() in error path.
- Rename stm32_omm_enable_child_clock() to stm32_omm_toggle_child_clock().
- Reorder initialised/non-initialized variable in stm32_omm_configure()
and stm32_omm_probe().
- Move pm_runtime_disable() calls from stm32_omm_configure() to
stm32_omm_probe().
- Update children's clocks and reset management.
- Use of_platform_populate() to probe children.
- Add missing pm_runtime_disable().
- Remove useless stm32_omm_check_access's first parameter.
- Update OMM's dt-bindings by adding OSPI's clocks and resets.
- Update stm32mp251.dtsi by adding OSPI's clock and reset in OMM's node.
Changes in v5:
- Add Reviewed-by Krzysztof Kozlowski for patch 1 and 3.
Changes in v4:
- Add default value requested by Krzysztof for st,omm-req2ack-ns,
st,omm-cssel-ovr and st,omm-mux properties in st,stm32mp25-omm.yaml
- Remove constraint in free form test for st,omm-mux property.
- Fix drivers/memory/Kconfig by replacing TEST_COMPILE_ by COMPILE_TEST.
- Fix SPDX-License-Identifier for stm32-omm.c.
- Fix Kernel test robot by fixing dev_err() format in stm32-omm.c.
- Add missing pm_runtime_disable() in the error handling path in
stm32-omm.c.
- Replace an int by an unsigned int in stm32-omm.c
- Remove uneeded "," after terminator in stm32-omm.c.
- Update cover letter description to explain dependecies between
Octo Memory Manager and its 2 Octo SPI children.
Changes in v3:
- Squash defconfig patches 8 and 9.
- Update STM32 Octo Memory Manager controller bindings.
- Rename st,stm32-omm.yaml to st,stm32mp25-omm.yaml.
- Update STM32 OSPI controller bindings.
- Reorder DT properties in .dtsi and .dts files.
- Replace devm_reset_control_get_optional() by
devm_reset_control_get_optional_exclusive() in stm32_omm.c.
- Reintroduce region-memory-names management in stm32_omm.c.
- Rename stm32_ospi_tx_poll() and stm32_ospi_tx() to respectively to
stm32_ospi_poll() and stm32_ospi_xfer() in spi-stm32-ospi.c.
- Set SPI_CONTROLLER_HALF_DUPLEX in controller flags in spi-stm32-ospi.c.
Changes in v2:
- Move STM32 Octo Memory Manager controller driver and bindings from
misc to memory-controllers.
- Update STM32 OSPI controller bindings.
- Update STM32 Octo Memory Manager controller bindings.
- Update STM32 Octo Memory Manager driver to match bindings update.
- Update DT to match bindings update.
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
Patrice Chotard (7):
MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver
dt-bindings: memory-controllers: Add STM32 Octo Memory Manager controller
memory: Add STM32 Octo Memory Manager driver
arm64: dts: st: Add OMM node on stm32mp251
arm64: dts: st: Add ospi port1 pinctrl entries in stm32mp25-pinctrl.dtsi
arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board
arm64: defconfig: Enable STM32 Octo Memory Manager and OcstoSPI driver
.../memory-controllers/st,stm32mp25-omm.yaml | 226 ++++++++++
MAINTAINERS | 6 +
arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 51 +++
arch/arm64/boot/dts/st/stm32mp251.dtsi | 54 +++
arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 32 ++
arch/arm64/configs/defconfig | 2 +
drivers/memory/Kconfig | 17 +
drivers/memory/Makefile | 1 +
drivers/memory/stm32_omm.c | 474 +++++++++++++++++++++
9 files changed, 863 insertions(+)
---
base-commit: 88424abd55ab36c3565898a656589a0a25ecd92f
change-id: 20250320-upstream_ospi_v6-d432a8172105
Best regards,
--
Patrice Chotard <patrice.chotard@foss.st.com>
On Mon, Apr 07, 2025 at 03:27:31PM GMT, Patrice Chotard wrote: > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > --- > Patrice Chotard (7): > MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver > dt-bindings: memory-controllers: Add STM32 Octo Memory Manager controller > memory: Add STM32 Octo Memory Manager driver > arm64: dts: st: Add OMM node on stm32mp251 > arm64: dts: st: Add ospi port1 pinctrl entries in stm32mp25-pinctrl.dtsi > arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board > arm64: defconfig: Enable STM32 Octo Memory Manager and OcstoSPI driver > > .../memory-controllers/st,stm32mp25-omm.yaml | 226 ++++++++++ > MAINTAINERS | 6 + > arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 51 +++ > arch/arm64/boot/dts/st/stm32mp251.dtsi | 54 +++ > arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 32 ++ > arch/arm64/configs/defconfig | 2 + > drivers/memory/Kconfig | 17 + > drivers/memory/Makefile | 1 + > drivers/memory/stm32_omm.c | 474 +++++++++++++++++++++ > 9 files changed, 863 insertions(+) > --- > base-commit: 88424abd55ab36c3565898a656589a0a25ecd92f That's unknown commit. b4 diff '20250407-upstream_ospi_v6-v8-0-7b7716c1c1f6@foss.st.com' Using cached copy of the lookup --- Analyzing 81 messages in the thread Preparing fake-am for v7: MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver ERROR: Could not write fake-am tree --- Could not create fake-am range for lower series v7 I tried on latest next, on some March next, on latest mainline. It seems you use some weird base here, so anyway I won't be able to apply it. Please split the patchset per subsystem and send something based on maintainer tree (so for me my for-next branch), mainline (which is the same as for-next currently) or linux-next.... which would be the same as my for-next branch currently. Best regards, Krzysztof
On 4/8/25 08:38, Krzysztof Kozlowski wrote: > On Mon, Apr 07, 2025 at 03:27:31PM GMT, Patrice Chotard wrote: >> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >> --- >> Patrice Chotard (7): >> MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver >> dt-bindings: memory-controllers: Add STM32 Octo Memory Manager controller >> memory: Add STM32 Octo Memory Manager driver >> arm64: dts: st: Add OMM node on stm32mp251 >> arm64: dts: st: Add ospi port1 pinctrl entries in stm32mp25-pinctrl.dtsi >> arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board >> arm64: defconfig: Enable STM32 Octo Memory Manager and OcstoSPI driver >> >> .../memory-controllers/st,stm32mp25-omm.yaml | 226 ++++++++++ >> MAINTAINERS | 6 + >> arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 51 +++ >> arch/arm64/boot/dts/st/stm32mp251.dtsi | 54 +++ >> arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 32 ++ >> arch/arm64/configs/defconfig | 2 + >> drivers/memory/Kconfig | 17 + >> drivers/memory/Makefile | 1 + >> drivers/memory/stm32_omm.c | 474 +++++++++++++++++++++ >> 9 files changed, 863 insertions(+) >> --- >> base-commit: 88424abd55ab36c3565898a656589a0a25ecd92f > > That's unknown commit. > > b4 diff '20250407-upstream_ospi_v6-v8-0-7b7716c1c1f6@foss.st.com' > Using cached copy of the lookup > --- > Analyzing 81 messages in the thread > Preparing fake-am for v7: MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver > ERROR: Could not write fake-am tree > --- > Could not create fake-am range for lower series v7 > > I tried on latest next, on some March next, on latest mainline. It seems > you use some weird base here, so anyway I won't be able to apply it. It was based on next-20250317 plus the 2 ospi patches already merged by Mark Brown, that's why. > > Please split the patchset per subsystem and send something based on > maintainer tree (so for me my for-next branch), mainline (which is the > same as for-next currently) or linux-next.... which would be the same as > my for-next branch currently. ok Thanks Patrice > > Best regards, > Krzysztof >
On 4/9/25 17:54, Patrice CHOTARD wrote: > > > On 4/8/25 08:38, Krzysztof Kozlowski wrote: >> On Mon, Apr 07, 2025 at 03:27:31PM GMT, Patrice Chotard wrote: >>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> >>> --- >>> Patrice Chotard (7): >>> MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver >>> dt-bindings: memory-controllers: Add STM32 Octo Memory Manager controller >>> memory: Add STM32 Octo Memory Manager driver >>> arm64: dts: st: Add OMM node on stm32mp251 >>> arm64: dts: st: Add ospi port1 pinctrl entries in stm32mp25-pinctrl.dtsi >>> arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board >>> arm64: defconfig: Enable STM32 Octo Memory Manager and OcstoSPI driver >>> >>> .../memory-controllers/st,stm32mp25-omm.yaml | 226 ++++++++++ >>> MAINTAINERS | 6 + >>> arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 51 +++ >>> arch/arm64/boot/dts/st/stm32mp251.dtsi | 54 +++ >>> arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 32 ++ >>> arch/arm64/configs/defconfig | 2 + >>> drivers/memory/Kconfig | 17 + >>> drivers/memory/Makefile | 1 + >>> drivers/memory/stm32_omm.c | 474 +++++++++++++++++++++ >>> 9 files changed, 863 insertions(+) >>> --- >>> base-commit: 88424abd55ab36c3565898a656589a0a25ecd92f >> >> That's unknown commit. >> >> b4 diff '20250407-upstream_ospi_v6-v8-0-7b7716c1c1f6@foss.st.com' >> Using cached copy of the lookup >> --- >> Analyzing 81 messages in the thread >> Preparing fake-am for v7: MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver >> ERROR: Could not write fake-am tree >> --- >> Could not create fake-am range for lower series v7 >> >> I tried on latest next, on some March next, on latest mainline. It seems >> you use some weird base here, so anyway I won't be able to apply it. > > It was based on next-20250317 plus the 2 ospi patches already merged > by Mark Brown, that's why. > >> >> Please split the patchset per subsystem and send something based on >> maintainer tree (so for me my for-next branch), mainline (which is the >> same as for-next currently) or linux-next.... which would be the same as >> my for-next branch currently. > > ok For memory-controller subsystem i will include: _ memory controller dt-bindings _ memory controller driver _ defconfig update _ Maintainers file update Are you ok with this proposal ? Patrice > > Thanks > Patrice > >> >> Best regards, >> Krzysztof >> > _______________________________________________ > Linux-stm32 mailing list > Linux-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
On 09/04/2025 18:13, Patrice CHOTARD wrote: >> >>> >>> Please split the patchset per subsystem and send something based on >>> maintainer tree (so for me my for-next branch), mainline (which is the >>> same as for-next currently) or linux-next.... which would be the same as >>> my for-next branch currently. >> >> ok > > For memory-controller subsystem i will include: > _ memory controller dt-bindings > _ memory controller driver > _ defconfig update > _ Maintainers file update defconfig should rather go to arm-soc. Rest is fine. Best regards, Krzysztof
On Tue, Apr 08, 2025 at 08:38:08AM GMT, Krzysztof Kozlowski wrote: > On Mon, Apr 07, 2025 at 03:27:31PM GMT, Patrice Chotard wrote: > > Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com> > > --- > > Patrice Chotard (7): > > MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver > > dt-bindings: memory-controllers: Add STM32 Octo Memory Manager controller > > memory: Add STM32 Octo Memory Manager driver > > arm64: dts: st: Add OMM node on stm32mp251 > > arm64: dts: st: Add ospi port1 pinctrl entries in stm32mp25-pinctrl.dtsi > > arm64: dts: st: Add SPI NOR flash support on stm32mp257f-ev1 board > > arm64: defconfig: Enable STM32 Octo Memory Manager and OcstoSPI driver > > > > .../memory-controllers/st,stm32mp25-omm.yaml | 226 ++++++++++ > > MAINTAINERS | 6 + > > arch/arm64/boot/dts/st/stm32mp25-pinctrl.dtsi | 51 +++ > > arch/arm64/boot/dts/st/stm32mp251.dtsi | 54 +++ > > arch/arm64/boot/dts/st/stm32mp257f-ev1.dts | 32 ++ > > arch/arm64/configs/defconfig | 2 + > > drivers/memory/Kconfig | 17 + > > drivers/memory/Makefile | 1 + > > drivers/memory/stm32_omm.c | 474 +++++++++++++++++++++ > > 9 files changed, 863 insertions(+) > > --- > > base-commit: 88424abd55ab36c3565898a656589a0a25ecd92f > > That's unknown commit. > > b4 diff '20250407-upstream_ospi_v6-v8-0-7b7716c1c1f6@foss.st.com' > Using cached copy of the lookup > --- > Analyzing 81 messages in the thread > Preparing fake-am for v7: MAINTAINERS: add entry for STM32 OCTO MEMORY MANAGER driver > ERROR: Could not write fake-am tree > --- > Could not create fake-am range for lower series v7 Hm, both v7 and v8 apply cleanly on next, so not sure why fake-am failed. Best regards, Krzysztof
© 2016 - 2025 Red Hat, Inc.