[PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y

Bartosz Golaszewski posted 12 patches 8 months, 1 week ago
[PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y
Posted by Bartosz Golaszewski 8 months, 1 week ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Extend the build coverage by allowing to build the module with
COMPILE_TEST enabled.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index decd150810b7..c13b95813c6c 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -368,8 +368,7 @@ config GPIO_HLWD
 
 config GPIO_ICH
 	tristate "Intel ICH GPIO"
-	depends on X86
-	depends on LPC_ICH
+	depends on (X86 && LPC_ICH) || COMPILE_TEST
 	help
 	  Say yes here to support the GPIO functionality of a number of Intel
 	  ICH-based chipsets.  Currently supported devices: ICH6, ICH7, ICH8

-- 
2.45.2
Re: [PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y
Posted by Linus Walleij 8 months ago
On Mon, Apr 7, 2025 at 9:13 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Extend the build coverage by allowing to build the module with
> COMPILE_TEST enabled.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Re: [PATCH 11/12] gpio: ich: enable building with COMPILE_TEST=y
Posted by Andy Shevchenko 8 months, 1 week ago
On Mon, Apr 07, 2025 at 09:13:20AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Extend the build coverage by allowing to build the module with
> COMPILE_TEST enabled.

...

>  config GPIO_ICH
>  	tristate "Intel ICH GPIO"
> -	depends on X86
> -	depends on LPC_ICH
> +	depends on (X86 && LPC_ICH) || COMPILE_TEST

I don't see why LPC_ICH should be here.
We do all-or-none approach for compile test for (x86) MFD drivers,
no need to test it separately (it makes a little sense).

	depends on X86 || COMPILE_TEST
	depends on LPC_ICH

-- 
With Best Regards,
Andy Shevchenko