[PATCH] selftests/futex: futex_waitv wouldblock test should fail

Edward Liaw posted 1 patch 10 months, 1 week ago
.../testing/selftests/futex/functional/futex_wait_wouldblock.c  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] selftests/futex: futex_waitv wouldblock test should fail
Posted by Edward Liaw 10 months, 1 week ago
Testcase should fail if -EWOULDBLOCK is not returned when expected value
differs from actual value from the waiter.

Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
Signed-off-by: Edward Liaw <edliaw@google.com>
---
 .../testing/selftests/futex/functional/futex_wait_wouldblock.c  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c b/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c
index 7d7a6a06cdb7..2d8230da9064 100644
--- a/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c
+++ b/tools/testing/selftests/futex/functional/futex_wait_wouldblock.c
@@ -98,7 +98,7 @@ int main(int argc, char *argv[])
 	info("Calling futex_waitv on f1: %u @ %p with val=%u\n", f1, &f1, f1+1);
 	res = futex_waitv(&waitv, 1, 0, &to, CLOCK_MONOTONIC);
 	if (!res || errno != EWOULDBLOCK) {
-		ksft_test_result_pass("futex_waitv returned: %d %s\n",
+		ksft_test_result_fail("futex_waitv returned: %d %s\n",
 				      res ? errno : res,
 				      res ? strerror(errno) : "");
 		ret = RET_FAIL;
-- 
2.49.0.504.g3bcea36a83-goog
Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail
Posted by André Almeida 10 months ago
Thank you Edward,

Em 04/04/2025 19:12, Edward Liaw escreveu:
> Testcase should fail if -EWOULDBLOCK is not returned when expected value
> differs from actual value from the waiter.
> 
> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
> Signed-off-by: Edward Liaw <edliaw@google.com>

Reviewed-by: André Almeida <andrealmeid@igalia.com>
Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail
Posted by Shuah Khan 10 months ago
On 4/8/25 08:21, André Almeida wrote:
> Thank you Edward,
> 
> Em 04/04/2025 19:12, Edward Liaw escreveu:
>> Testcase should fail if -EWOULDBLOCK is not returned when expected value
>> differs from actual value from the waiter.
>>
>> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
>> Signed-off-by: Edward Liaw <edliaw@google.com>
> 
> Reviewed-by: André Almeida <andrealmeid@igalia.com>
> 

Thank you. Applied for Linux 6.15-rc2

https://web.git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=fixes

thanks,
-- Shuah
Re: [PATCH] selftests/futex: futex_waitv wouldblock test should fail
Posted by Thomas Gleixner 10 months ago
On Fri, Apr 04 2025 at 22:12, Edward Liaw wrote:

> Testcase should fail if -EWOULDBLOCK is not returned when expected value
> differs from actual value from the waiter.
>
> Fixes: 9d57f7c79748920636f8293d2f01192d702fe390 ("selftests: futex: Test sys_futex_waitv() wouldblock")
> Signed-off-by: Edward Liaw <edliaw@google.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>