watchdog: Do not enable by default during compile testing

[PATCH] watchdog: Do not enable by default during compile testing

Posted by Krzysztof Kozlowski 10 months, 1 week ago

Enabling the compile test should not cause automatic enabling of all
drivers.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/watchdog/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 0d8d37f712e8..1d29e5f4f40c 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1001,7 +1001,7 @@ config STM32_WATCHDOG
 	tristate "STM32 Independent WatchDoG (IWDG) support"
 	depends on ARCH_STM32 || COMPILE_TEST
 	select WATCHDOG_CORE
-	default y
+	default ARCH_STM32
 	help
 	  Say Y here to include support for the watchdog timer
 	  in stm32 SoCs.
@@ -1869,7 +1869,7 @@ config OCTEON_WDT
 config MARVELL_GTI_WDT
 	tristate "Marvell GTI Watchdog driver"
 	depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
-	default y
+	default ARCH_THUNDER
 	select WATCHDOG_CORE
 	help
 	  Marvell GTI hardware supports watchdog timer. First timeout
@@ -2035,7 +2035,7 @@ config 8xxx_WDT
 config PIKA_WDT
 	tristate "PIKA FPGA Watchdog"
 	depends on WARP || (PPC64 && COMPILE_TEST)
-	default y
+	default WARP
 	help
 	  This enables the watchdog in the PIKA FPGA. Currently used on
 	  the Warp platform.
-- 
2.45.2

Re: [PATCH] watchdog: Do not enable by default during compile testing

Posted by Guenter Roeck 10 months, 1 week ago

On 4/4/25 05:39, Krzysztof Kozlowski wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Re: [PATCH] watchdog: Do not enable by default during compile testing

Posted by Guenter Roeck 10 months, 1 week ago

On 4/4/25 05:39, Krzysztof Kozlowski wrote:
> Enabling the compile test should not cause automatic enabling of all
> drivers.
> 

Sorry, I seem to be missing something.

Isn't that what COMPILE_TEST is all about, that it enables everything ?

Guenter

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   drivers/watchdog/Kconfig | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 0d8d37f712e8..1d29e5f4f40c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1001,7 +1001,7 @@ config STM32_WATCHDOG
>   	tristate "STM32 Independent WatchDoG (IWDG) support"
>   	depends on ARCH_STM32 || COMPILE_TEST
>   	select WATCHDOG_CORE
> -	default y
> +	default ARCH_STM32
>   	help
>   	  Say Y here to include support for the watchdog timer
>   	  in stm32 SoCs.
> @@ -1869,7 +1869,7 @@ config OCTEON_WDT
>   config MARVELL_GTI_WDT
>   	tristate "Marvell GTI Watchdog driver"
>   	depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> -	default y
> +	default ARCH_THUNDER
>   	select WATCHDOG_CORE
>   	help
>   	  Marvell GTI hardware supports watchdog timer. First timeout
> @@ -2035,7 +2035,7 @@ config 8xxx_WDT
>   config PIKA_WDT
>   	tristate "PIKA FPGA Watchdog"
>   	depends on WARP || (PPC64 && COMPILE_TEST)
> -	default y
> +	default WARP
>   	help
>   	  This enables the watchdog in the PIKA FPGA. Currently used on
>   	  the Warp platform.

Re: [PATCH] watchdog: Do not enable by default during compile testing

Posted by Krzysztof Kozlowski 10 months, 1 week ago

On 04/04/2025 14:49, Guenter Roeck wrote:
> On 4/4/25 05:39, Krzysztof Kozlowski wrote:
>> Enabling the compile test should not cause automatic enabling of all
>> drivers.
>>
> 
> Sorry, I seem to be missing something.
> 
> Isn't that what COMPILE_TEST is all about, that it enables everything ?

No. Compile test *allows* to compile test, but it does not mean you want
immediately compile everything. allyesconfig is for everything. Maybe
you want to compile some subset of drivers.

BTW, I am aligning with the most frequent pattern (quickly judging), so
of course I also accept argument that we should revert that other
pattern and use "default y" everywhere.

Best regards,
Krzysztof

Re: [PATCH] watchdog: Do not enable by default during compile testing

Posted by Guenter Roeck 10 months, 1 week ago

On 4/4/25 05:57, Krzysztof Kozlowski wrote:
> On 04/04/2025 14:49, Guenter Roeck wrote:
>> On 4/4/25 05:39, Krzysztof Kozlowski wrote:
>>> Enabling the compile test should not cause automatic enabling of all
>>> drivers.
>>>
>>
>> Sorry, I seem to be missing something.
>>
>> Isn't that what COMPILE_TEST is all about, that it enables everything ?
> 
> No. Compile test *allows* to compile test, but it does not mean you want
> immediately compile everything. allyesconfig is for everything. Maybe
> you want to compile some subset of drivers.
> 
> BTW, I am aligning with the most frequent pattern (quickly judging), so
> of course I also accept argument that we should revert that other
> pattern and use "default y" everywhere.
> 

NP. We live and learn.

Guenter

Re: [PATCH] watchdog: Do not enable by default during compile testing

Posted by Krzysztof Kozlowski 10 months, 1 week ago

On 04/04/2025 14:57, Krzysztof Kozlowski wrote:
> On 04/04/2025 14:49, Guenter Roeck wrote:
>> On 4/4/25 05:39, Krzysztof Kozlowski wrote:
>>> Enabling the compile test should not cause automatic enabling of all
>>> drivers.
>>>
>>
>> Sorry, I seem to be missing something.
>>
>> Isn't that what COMPILE_TEST is all about, that it enables everything ?
> 
> No. Compile test *allows* to compile test, but it does not mean you want
> immediately compile everything. allyesconfig is for everything. Maybe
> you want to compile some subset of drivers.
> 
> BTW, I am aligning with the most frequent pattern (quickly judging), so
> of course I also accept argument that we should revert that other
> pattern and use "default y" everywhere.

+Cc Arnd,

I also dug out old recommendation from Arnd (so I am not making this
stuff up):

https://lore.kernel.org/lkml/CAK8P3a1TY+XT1vF=wAh0XA5BXU5Z6Ab1d4DekXbVsN9aj3aL5w@mail.gmail.com/

Best regards,
Krzysztof

Re: [PATCH] watchdog: Do not enable by default during compile testing

Posted by Arnd Bergmann 10 months, 1 week ago

On Fri, Apr 4, 2025, at 14:59, Krzysztof Kozlowski wrote:
> On 04/04/2025 14:57, Krzysztof Kozlowski wrote:
>> On 04/04/2025 14:49, Guenter Roeck wrote:
>>> On 4/4/25 05:39, Krzysztof Kozlowski wrote:
>>>> Enabling the compile test should not cause automatic enabling of all
>>>> drivers.
>>>>
>>>
>>> Sorry, I seem to be missing something.
>>>
>>> Isn't that what COMPILE_TEST is all about, that it enables everything ?
>> 
>> No. Compile test *allows* to compile test, but it does not mean you want
>> immediately compile everything. allyesconfig is for everything. Maybe
>> you want to compile some subset of drivers.
>> 
>> BTW, I am aligning with the most frequent pattern (quickly judging), so
>> of course I also accept argument that we should revert that other
>> pattern and use "default y" everywhere.
>
> I also dug out old recommendation from Arnd (so I am not making this
> stuff up):

Right, I agree with your patch here: COMPILE_TEST=y should make a
lot more options visible but not generally enable those.

Note that COMPILE_TEST=y also turns *off* some other options in
order to speed up the (allmodconfig) build process and avoid
some options that are unhelp for finding build issues:

lib/Kconfig.kasan-config KASAN_STACK
lib/Kconfig.kasan:      bool "Stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST
security/Kconfig.hardening-config GCC_PLUGIN_STACKLEAK_VERBOSE
security/Kconfig.hardening-     bool "Report stack depth analysis instrumentation" if EXPERT
security/Kconfig.hardening-     depends on GCC_PLUGIN_STACKLEAK
security/Kconfig.hardening:     depends on !COMPILE_TEST        # too noisy
kernel/gcov/Kconfig-config GCOV_PROFILE_ALL
kernel/gcov/Kconfig-    bool "Profile entire Kernel"
kernel/gcov/Kconfig:    depends on !COMPILE_TEST

     Arnd