1. Patchew
  2. linux
  3. [PATCH 0/4] dt-bindings: clock: ti: convert to yaml
  4. View patch

[PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference

Sukrut Bellary posted 4 patches 10 months, 1 week ago
There is a newer version of this series
[PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference
Posted by Sukrut Bellary 10 months, 1 week ago 
ti,divider-clock uses properties from ti,autoidle.

As we are converting autoidle binding to ti,autoidle.yaml,
fix the reference here.

Add dual license.

Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
---
 .../bindings/clock/ti/ti,divider-clock.yaml   | 24 ++++---------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
index 3fbe236eb565..aba879ae302d 100644
--- a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
@@ -1,4 +1,4 @@
-# SPDX-License-Identifier: GPL-2.0-only
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 %YAML 1.2
 ---
 $id: http://devicetree.org/schemas/clock/ti/ti,divider-clock.yaml#
@@ -55,9 +55,10 @@ description: |
   is missing it is the same as supplying a zero shift.
 
   This binding can also optionally provide support to the hardware autoidle
-  feature, see [1].
+  feature.
 
-  [1] Documentation/devicetree/bindings/clock/ti/autoidle.txt
+allOf:
+  - $ref: /schemas/clock/ti/ti,autoidle.yaml#
 
 properties:
   compatible:
@@ -97,7 +98,6 @@ properties:
     minimum: 1
     default: 1
 
-
   ti,max-div:
     $ref: /schemas/types.yaml#/definitions/uint32
     description:
@@ -116,20 +116,6 @@ properties:
       valid divisor programming must be a power of two,
       only valid if ti,dividers is not defined.
 
-  ti,autoidle-shift:
-    $ref: /schemas/types.yaml#/definitions/uint32
-    description:
-      bit shift of the autoidle enable bit for the clock,
-      see [1].
-    maximum: 31
-    default: 0
-
-  ti,invert-autoidle-bit:
-    type: boolean
-    description:
-      autoidle is enabled by setting the bit to 0,
-      see [1]
-
   ti,set-rate-parent:
     type: boolean
     description:
@@ -156,7 +142,7 @@ required:
   - clocks
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1
Re: [PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference
Posted by Andreas Kemnade 10 months, 1 week ago 
Am Thu,  3 Apr 2025 18:45:00 -0700
schrieb Sukrut Bellary <sbellary@baylibre.com>:

> ti,divider-clock uses properties from ti,autoidle.
> 
> As we are converting autoidle binding to ti,autoidle.yaml,
> fix the reference here.
> 
> Add dual license.
> 
> Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
> ---
>  .../bindings/clock/ti/ti,divider-clock.yaml   | 24 ++++---------------
>  1 file changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> index 3fbe236eb565..aba879ae302d 100644
> --- a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> @@ -1,4 +1,4 @@
> -# SPDX-License-Identifier: GPL-2.0-only
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>  %YAML 1.2
>  ---
>  $id: http://devicetree.org/schemas/clock/ti/ti,divider-clock.yaml#
> @@ -55,9 +55,10 @@ description: |
>    is missing it is the same as supplying a zero shift.
>  
>    This binding can also optionally provide support to the hardware autoidle
> -  feature, see [1].
> +  feature.
>  
> -  [1] Documentation/devicetree/bindings/clock/ti/autoidle.txt
> +allOf:
> +  - $ref: /schemas/clock/ti/ti,autoidle.yaml#
>  
>  properties:
>    compatible:
> @@ -97,7 +98,6 @@ properties:
>      minimum: 1
>      default: 1
>  
> -
>    ti,max-div:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description:
> @@ -116,20 +116,6 @@ properties:
>        valid divisor programming must be a power of two,
>        only valid if ti,dividers is not defined.
>  
> -  ti,autoidle-shift:
> -    $ref: /schemas/types.yaml#/definitions/uint32
> -    description:
> -      bit shift of the autoidle enable bit for the clock,
> -      see [1].
> -    maximum: 31
> -    default: 0
> -
now you make ti,autoidle-shift required. That makes so sense. A clock
does not necessarily support autoidle.

Regards,
Andreas
Re: [PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference
Posted by Sukrut Bellary 10 months ago 
On Sat, Apr 05, 2025 at 09:49:04PM +0200, Andreas Kemnade wrote:
> Am Thu,  3 Apr 2025 18:45:00 -0700
> schrieb Sukrut Bellary <sbellary@baylibre.com>:
> 
> > ti,divider-clock uses properties from ti,autoidle.
> > 
> > As we are converting autoidle binding to ti,autoidle.yaml,
> > fix the reference here.
> > 
> > Add dual license.
> > 
> > Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
> > ---
> >  .../bindings/clock/ti/ti,divider-clock.yaml   | 24 ++++---------------
> >  1 file changed, 5 insertions(+), 19 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> > index 3fbe236eb565..aba879ae302d 100644
> > --- a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> > @@ -1,4 +1,4 @@
> > -# SPDX-License-Identifier: GPL-2.0-only
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >  %YAML 1.2
> >  ---
> >  $id: http://devicetree.org/schemas/clock/ti/ti,divider-clock.yaml#
> > @@ -55,9 +55,10 @@ description: |
> >    is missing it is the same as supplying a zero shift.
> >  
> >    This binding can also optionally provide support to the hardware autoidle
> > -  feature, see [1].
> > +  feature.
> >  
> > -  [1] Documentation/devicetree/bindings/clock/ti/autoidle.txt
> > +allOf:
> > +  - $ref: /schemas/clock/ti/ti,autoidle.yaml#
> >  
> >  properties:
> >    compatible:
> > @@ -97,7 +98,6 @@ properties:
> >      minimum: 1
> >      default: 1
> >  
> > -
> >    ti,max-div:
> >      $ref: /schemas/types.yaml#/definitions/uint32
> >      description:
> > @@ -116,20 +116,6 @@ properties:
> >        valid divisor programming must be a power of two,
> >        only valid if ti,dividers is not defined.
> >  
> > -  ti,autoidle-shift:
> > -    $ref: /schemas/types.yaml#/definitions/uint32
> > -    description:
> > -      bit shift of the autoidle enable bit for the clock,
> > -      see [1].
> > -    maximum: 31
> > -    default: 0
> > -
> now you make ti,autoidle-shift required. That makes so sense. A clock
> does not necessarily support autoidle.

Thanks for the review.
No, we are removing the required from yaml bindings and keeping it as
one of the properties. As all clock don't support autoidle, required is
not applicable here.

> Regards,
> Andreas
Re: [PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference
Posted by Rob Herring 10 months, 1 week ago 
On Thu, Apr 03, 2025 at 06:45:00PM -0700, Sukrut Bellary wrote:
> ti,divider-clock uses properties from ti,autoidle.
> 
> As we are converting autoidle binding to ti,autoidle.yaml,
> fix the reference here.
> 
> Add dual license.

Do you have rights to do so?

> 
> Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
> ---
>  .../bindings/clock/ti/ti,divider-clock.yaml   | 24 ++++---------------
>  1 file changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> index 3fbe236eb565..aba879ae302d 100644
> --- a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> @@ -1,4 +1,4 @@
> -# SPDX-License-Identifier: GPL-2.0-only
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>  %YAML 1.2
>  ---
>  $id: http://devicetree.org/schemas/clock/ti/ti,divider-clock.yaml#
> @@ -55,9 +55,10 @@ description: |
>    is missing it is the same as supplying a zero shift.
>  
>    This binding can also optionally provide support to the hardware autoidle
> -  feature, see [1].
> +  feature.
>  
> -  [1] Documentation/devicetree/bindings/clock/ti/autoidle.txt
> +allOf:
> +  - $ref: /schemas/clock/ti/ti,autoidle.yaml#
>  
>  properties:
>    compatible:
> @@ -97,7 +98,6 @@ properties:
>      minimum: 1
>      default: 1
>  
> -
>    ti,max-div:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description:
> @@ -116,20 +116,6 @@ properties:
>        valid divisor programming must be a power of two,
>        only valid if ti,dividers is not defined.
>  
> -  ti,autoidle-shift:
> -    $ref: /schemas/types.yaml#/definitions/uint32
> -    description:
> -      bit shift of the autoidle enable bit for the clock,
> -      see [1].
> -    maximum: 31
> -    default: 0
> -
> -  ti,invert-autoidle-bit:
> -    type: boolean
> -    description:
> -      autoidle is enabled by setting the bit to 0,
> -      see [1]
> -
>    ti,set-rate-parent:
>      type: boolean
>      description:
> @@ -156,7 +142,7 @@ required:
>    - clocks
>    - reg
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.34.1
>
Re: [PATCH 4/4] dt-bindings: clock: ti: add ti,autoidle.yaml reference
Posted by Sukrut Bellary 10 months ago 
On Fri, Apr 04, 2025 at 02:42:06PM -0500, Rob Herring wrote:
> On Thu, Apr 03, 2025 at 06:45:00PM -0700, Sukrut Bellary wrote:
> > ti,divider-clock uses properties from ti,autoidle.
> > 
> > As we are converting autoidle binding to ti,autoidle.yaml,
> > fix the reference here.
> > 
> > Add dual license.
> 
> Do you have rights to do so?

I will keep it as is.
May be Andreas can take care of this.

> > 
> > Signed-off-by: Sukrut Bellary <sbellary@baylibre.com>
> > ---
> >  .../bindings/clock/ti/ti,divider-clock.yaml   | 24 ++++---------------
> >  1 file changed, 5 insertions(+), 19 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> > index 3fbe236eb565..aba879ae302d 100644
> > --- a/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml
> > @@ -1,4 +1,4 @@
> > -# SPDX-License-Identifier: GPL-2.0-only
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >  %YAML 1.2
> >  ---
> >  $id: http://devicetree.org/schemas/clock/ti/ti,divider-clock.yaml#
> > @@ -55,9 +55,10 @@ description: |
> >    is missing it is the same as supplying a zero shift.
> >  
> >    This binding can also optionally provide support to the hardware autoidle
> > -  feature, see [1].
> > +  feature.
> >  
> > -  [1] Documentation/devicetree/bindings/clock/ti/autoidle.txt
> > +allOf:
> > +  - $ref: /schemas/clock/ti/ti,autoidle.yaml#
> >  
> >  properties:
> >    compatible:
> > @@ -97,7 +98,6 @@ properties:
> >      minimum: 1
> >      default: 1
> >  
> > -
> >    ti,max-div:
> >      $ref: /schemas/types.yaml#/definitions/uint32
> >      description:
> > @@ -116,20 +116,6 @@ properties:
> >        valid divisor programming must be a power of two,
> >        only valid if ti,dividers is not defined.
> >  
> > -  ti,autoidle-shift:
> > -    $ref: /schemas/types.yaml#/definitions/uint32
> > -    description:
> > -      bit shift of the autoidle enable bit for the clock,
> > -      see [1].
> > -    maximum: 31
> > -    default: 0
> > -
> > -  ti,invert-autoidle-bit:
> > -    type: boolean
> > -    description:
> > -      autoidle is enabled by setting the bit to 0,
> > -      see [1]
> > -
> >    ti,set-rate-parent:
> >      type: boolean
> >      description:
> > @@ -156,7 +142,7 @@ required:
> >    - clocks
> >    - reg
> >  
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >  
> >  examples:
> >    - |
> > -- 
> > 2.34.1
> >

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.