This series addresses several minor issues found using sparse.

[PATCH 0/3] This series addresses several minor issues found using sparse.

Posted by Gabriel Shahrouzi 8 months, 2 weeks ago

The first patch fixes a typo ('\%u') in a format specifier within a print
statement. The incorrect sequence was replaced as it didn't appear
to be the author's intent.

The second patch corrects the type for a function argument to __le64,
which fixes two related sparse warnings. Although the argument data
is already little-endian, using the specific __le64 type improves
consistency and makes the expected data format explicit.

The third patch ensures cpu_to_le16() is used when preparing certain
on-disk data (directory entry lengths). This maintains correct byte
ordering for big-endian systems.

Gabriel Shahrouzi (3):
  bcachefs: Fix escape sequence in prt_printf
  bcachefs: Fix type for parameter in
    journal_advance_devs_to_next_bucket
  bcachefs: Use cpu_to_le16 for dirent lengths

 fs/bcachefs/data_update.c | 2 +-
 fs/bcachefs/dirent.c      | 4 ++--
 fs/bcachefs/journal_io.c  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.43.0

Re: [PATCH 0/3] This series addresses several minor issues found using sparse.

Posted by Kent Overstreet 8 months, 2 weeks ago

On Thu, Apr 03, 2025 at 09:28:19PM -0400, Gabriel Shahrouzi wrote:
> The first patch fixes a typo ('\%u') in a format specifier within a print
> statement. The incorrect sequence was replaced as it didn't appear
> to be the author's intent.
> 
> The second patch corrects the type for a function argument to __le64,
> which fixes two related sparse warnings. Although the argument data
> is already little-endian, using the specific __le64 type improves
> consistency and makes the expected data format explicit.
> 
> The third patch ensures cpu_to_le16() is used when preparing certain
> on-disk data (directory entry lengths). This maintains correct byte
> ordering for big-endian systems.

Thanks, series is applied.

> 
> Gabriel Shahrouzi (3):
>   bcachefs: Fix escape sequence in prt_printf
>   bcachefs: Fix type for parameter in
>     journal_advance_devs_to_next_bucket
>   bcachefs: Use cpu_to_le16 for dirent lengths
> 
>  fs/bcachefs/data_update.c | 2 +-
>  fs/bcachefs/dirent.c      | 4 ++--
>  fs/bcachefs/journal_io.c  | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.43.0
>