pinctrl: qcom: Use devm_platform_ioremap_resource_byname

[PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname

Posted by shao.mingyin@zte.com.cn 1 day, 3 hours ago

From: Xie Ludan <xie.ludan@zte.com.cn>

Introduce devm_platform_ioremap_resource_byname() to simplify
resource retrieval and mapping.This new function consolidates
platform_get_resource_byname() and devm_ioremap_resource() into a single
call, improving code readability and reducing API call overhead.

Signed-off-by: Xie Ludan <xie.ludan@zte.com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
---
 drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 13cdd6c0fbd7..264ac0e7152d 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -1548,7 +1548,7 @@ int msm_pinctrl_probe(struct platform_device *pdev,

 	if (soc_data->tiles) {
 		for (i = 0; i < soc_data->ntiles; i++) {
-			pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev, 
+			pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
 																   soc_data->tiles[i]);
 			if (IS_ERR(pctrl->regs[i]))
 				return PTR_ERR(pctrl->regs[i]);
-- 
2.25.1

Re: [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname

Posted by Dmitry Baryshkov 23 hours ago

On Thu, Apr 03, 2025 at 03:50:14PM +0800, shao.mingyin@zte.com.cn wrote:
> From: Xie Ludan <xie.ludan@zte.com.cn>
> 
> Introduce devm_platform_ioremap_resource_byname() to simplify
> resource retrieval and mapping.This new function consolidates
> platform_get_resource_byname() and devm_ioremap_resource() into a single
> call, improving code readability and reducing API call overhead.

Commit message is incorrect. You are not introducing anything, you are
removing a whitespace.

> 
> Signed-off-by: Xie Ludan <xie.ludan@zte.com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
> ---
>  drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 13cdd6c0fbd7..264ac0e7152d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -1548,7 +1548,7 @@ int msm_pinctrl_probe(struct platform_device *pdev,
> 
>  	if (soc_data->tiles) {
>  		for (i = 0; i < soc_data->ntiles; i++) {
> -			pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev, 
> +			pctrl->regs[i] = devm_platform_ioremap_resource_byname(pdev,
>  																   soc_data->tiles[i]);
>  			if (IS_ERR(pctrl->regs[i]))
>  				return PTR_ERR(pctrl->regs[i]);
> -- 
> 2.25.1

-- 
With best wishes
Dmitry

Re: [PATCH] pinctrl: qcom: Use devm_platform_ioremap_resource_byname

Posted by Krzysztof Kozlowski 5 hours ago

On 03/04/2025 13:43, Dmitry Baryshkov wrote:
> On Thu, Apr 03, 2025 at 03:50:14PM +0800, shao.mingyin@zte.com.cn wrote:
>> From: Xie Ludan <xie.ludan@zte.com.cn>
>>
>> Introduce devm_platform_ioremap_resource_byname() to simplify
>> resource retrieval and mapping.This new function consolidates
>> platform_get_resource_byname() and devm_ioremap_resource() into a single
>> call, improving code readability and reducing API call overhead.
> 
> Commit message is incorrect. You are not introducing anything, you are
> removing a whitespace.
> 

This is another example of automated zte patches which sometimes are
note tested or make no sense. They still keep generating them via
automation and sending without actual review.

Best regards,
Krzysztof