[PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi

J. Neuschäfer via B4 Relay posted 2 patches 1 month, 1 week ago
[PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi
Posted by J. Neuschäfer via B4 Relay 1 month, 1 week ago
From: "J. Neuschäfer" <j.ne@posteo.net>

This is an on-board USB device that requires a 3.3V supply.

Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
---
 .../bindings/net/wireless/realtek,rtl8188.yaml     | 51 ++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188.yaml b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..b637c71e3c4d81b47d338394b2e0a7772035c2c7
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/wireless/realtek,rtl8188.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/wireless/realtek,rtl8188.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek RTL8188 USB WiFi
+
+maintainers:
+  - J. Neuschäfer <j.neuschaefer@gmx.net>
+
+description:
+  The Realtek RTL8188 is a USB-connected 2.4 GHz WiFi module.
+  TODO- website or soemthing
+
+allOf:
+  - $ref: /schemas/usb/usb-device.yaml#
+
+properties:
+  compatible:
+    const: usbbda,179
+
+  reg: true
+
+  vdd-supply:
+    description:
+      Regulator for the 3V3 supply.
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        wifi: wifi@1 {
+            compatible = "usbbda,179";
+            reg = <1>;
+            vdd-supply = <&vcc3v3>;
+        };
+    };
+
+...

-- 
2.48.0.rc1.219.gb6b6757d772


Re: [PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi
Posted by Rob Herring 1 month ago
On Thu, Apr 03, 2025 at 04:07:48PM +0200, J. Neuschäfer wrote:
> This is an on-board USB device that requires a 3.3V supply.
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
>  .../bindings/net/wireless/realtek,rtl8188.yaml     | 51 ++++++++++++++++++++++
>  1 file changed, 51 insertions(+)

Looks fine to me other than the issues pointed out.
Re: [PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi
Posted by Martin Blumenstingl 1 month ago
On Thu, Apr 3, 2025 at 4:07 PM J. Neuschäfer via B4 Relay
<devnull+j.ne.posteo.net@kernel.org> wrote:
[...]
> +description:
> +  The Realtek RTL8188 is a USB-connected 2.4 GHz WiFi module.
> +  TODO- website or soemthing
When you re-send this patch (to update the email address) please
delete the TODO (a website is not strictly necessary)
Re: [PATCH 1/2] dt-bindings: net: wireless: Add Realtek RTL8188 USB WiFi
Posted by J. Neuschäfer 1 month, 1 week ago
On Thu, Apr 03, 2025 at 04:07:48PM +0200, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@posteo.net>
> 
> This is an on-board USB device that requires a 3.3V supply.
> 
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
[...]
> +maintainers:
> +  - J. Neuschäfer <j.neuschaefer@gmx.net>

Sorry, typoed that. I wanted to use my current email address instead of
this old one. Will fix in v2.