[v2] ARM: dts: nuvoton: Add OHCI node

[PATCH v2] ARM: dts: nuvoton: Add OHCI node

Posted by William A. Kennington III 8 months, 2 weeks ago

The EHCI peripheral already exists in the devicetree, but the hardware
also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
works fine for this device already and has been tested on real hardware.

Signed-off-by: William A. Kennington III <william@wkennington.com>
---
V1 -> V2: Fixed nodename from ohci -> usb

 arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
index c7880126cc78..5a466e97955a 100644
--- a/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton/nuvoton-common-npcm7xx.dtsi
@@ -151,6 +151,13 @@ ehci1: usb@f0806000 {
 			status = "disabled";
 		};
 
+		ohci1: usb@f0807000 {
+			compatible = "generic-ohci";
+			reg = <0xf0807000 0x1000>;
+			interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		fiu0: spi@fb000000 {
 			compatible = "nuvoton,npcm750-fiu";
 			#address-cells = <1>;
-- 
2.49.0.472.ge94155a9ec-goog

Re: [PATCH v2] ARM: dts: nuvoton: Add OHCI node

Posted by Andrew Jeffery 8 months, 2 weeks ago

On Tue, 01 Apr 2025 16:34:09 -0700, William A. Kennington III wrote:
> The EHCI peripheral already exists in the devicetree, but the hardware
> also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
> works fine for this device already and has been tested on real hardware.
> 
> 

Thanks, I've applied this to be picked up through the BMC tree.

-- 
Andrew Jeffery <andrew@codeconstruct.com.au>

Re: [PATCH v2] ARM: dts: nuvoton: Add OHCI node

Posted by Tomer Maimon 8 months ago

William, thanks for the patch.

Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>

On Thu, 3 Apr 2025 at 17:44, Andrew Jeffery <andrew@codeconstruct.com.au> wrote:
>
> On Tue, 01 Apr 2025 16:34:09 -0700, William A. Kennington III wrote:
> > The EHCI peripheral already exists in the devicetree, but the hardware
> > also supports a discrete OHCI unit on the same USB PHY. Generic OHCI
> > works fine for this device already and has been tested on real hardware.
> >
> >
>
> Thanks, I've applied this to be picked up through the BMC tree.
>
> --
> Andrew Jeffery <andrew@codeconstruct.com.au>
>