[v2] misc: tps6594-pfsm: Add NULL check in tps6594_pfsm_probe()

[PATCH v2] misc: tps6594-pfsm: Add NULL check in tps6594_pfsm_probe()

Henry Martin posted 1 patch 2 days, 20 hours ago

Diff against v1
Download mbox

drivers/misc/tps6594-pfsm.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[PATCH v2] misc: tps6594-pfsm: Add NULL check in tps6594_pfsm_probe()

Posted by Henry Martin 2 days, 20 hours ago

devm_kasprintf() returns NULL when memory allocation fails. Currently,
tps6594_pfsm_probe() does not check for this case, which results in a
NULL pointer dereference.

Add NULL check after devm_kasprintf() to prevent this issue.

Cc: stable@vger.kernel.org # 6.5+
Fixes: a0df3ef087f8 ("misc: tps6594-pfsm: Add driver for TI TPS6594 PFSM")
Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
---
V1 -> V2: Add Cc stable line.

 drivers/misc/tps6594-pfsm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/tps6594-pfsm.c b/drivers/misc/tps6594-pfsm.c
index 0a24ce44cc37..0d9dad20b6ae 100644
--- a/drivers/misc/tps6594-pfsm.c
+++ b/drivers/misc/tps6594-pfsm.c
@@ -281,6 +281,8 @@ static int tps6594_pfsm_probe(struct platform_device *pdev)
 	pfsm->miscdev.minor = MISC_DYNAMIC_MINOR;
 	pfsm->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "pfsm-%ld-0x%02x",
 					    tps->chip_id, tps->reg);
+	if (!pfsm->miscdev.name)
+		return -ENOMEM;
 	pfsm->miscdev.fops = &tps6594_pfsm_fops;
 	pfsm->miscdev.parent = dev->parent;
 	pfsm->chip_id = tps->chip_id;
-- 
2.34.1