[PATCH v3 0/3] netfilter: Make xt_cgroup independent from net_cls

Michal Koutný posted 3 patches 1 week, 2 days ago
include/linux/cgroup-defs.h | 10 ++++------
net/ipv4/inet_diag.c        |  2 +-
net/netfilter/Kconfig       |  2 +-
net/netfilter/xt_cgroup.c   | 26 ++++++++++++++++++++++++++
4 files changed, 32 insertions(+), 8 deletions(-)
[PATCH v3 0/3] netfilter: Make xt_cgroup independent from net_cls
Posted by Michal Koutný 1 week, 2 days ago
Changes from v2 (https://lore.kernel.org/r/20250305170935.80558-1-mkoutny@suse.com):
- don't accept zero classid neither (Pablo N. A.)
- eliminate code that might rely on comparison against zero with
  !CONFIG_CGROUP_NET_CLASSID

Michal Koutný (3):
  netfilter: Make xt_cgroup independent from net_cls
  cgroup: Guard users of sock_cgroup_classid()
  cgroup: Drop sock_cgroup_classid() dummy implementation

 include/linux/cgroup-defs.h | 10 ++++------
 net/ipv4/inet_diag.c        |  2 +-
 net/netfilter/Kconfig       |  2 +-
 net/netfilter/xt_cgroup.c   | 26 ++++++++++++++++++++++++++
 4 files changed, 32 insertions(+), 8 deletions(-)


base-commit: dd83757f6e686a2188997cb58b5975f744bb7786
-- 
2.48.1

Re: [PATCH v3 0/3] netfilter: Make xt_cgroup independent from net_cls
Posted by Michal Koutný 1 day, 2 hours ago
On Tue, Apr 01, 2025 at 01:57:29PM +0200, Michal Koutný <mkoutny@suse.com> wrote:
> Changes from v2 (https://lore.kernel.org/r/20250305170935.80558-1-mkoutny@suse.com):
> - don't accept zero classid neither (Pablo N. A.)
> - eliminate code that might rely on comparison against zero with
>   !CONFIG_CGROUP_NET_CLASSID

Pablo, just to break possible dilemma with Tejun's routing [1], it makes
sense to me to route this series together via net(filter) git(s).

Also, let me (anyone) know should there be further remarks to this form.

Thanks,
Michal

[1] https://lore.kernel.org/all/Z-zqvmJFI3PkNl6R@slm.duckdns.org/
Re: [PATCH v3 0/3] netfilter: Make xt_cgroup independent from net_cls
Posted by Tejun Heo 1 week, 1 day ago
On Tue, Apr 01, 2025 at 01:57:29PM +0200, Michal Koutný wrote:
> Changes from v2 (https://lore.kernel.org/r/20250305170935.80558-1-mkoutny@suse.com):
> - don't accept zero classid neither (Pablo N. A.)
> - eliminate code that might rely on comparison against zero with
>   !CONFIG_CGROUP_NET_CLASSID
> 
> Michal Koutný (3):
>   netfilter: Make xt_cgroup independent from net_cls
>   cgroup: Guard users of sock_cgroup_classid()
>   cgroup: Drop sock_cgroup_classid() dummy implementation

From cgroup POV:

  Acked-by: Tejun Heo <tj@kernel.org>

Once folks are happy, please let me know how the patches should be routed.

Thanks.

-- 
tejun