ftrace: Have tracing function args depend on PROBE_EVENTS_BTF_ARGS

[PATCH] ftrace: Have tracing function args depend on PROBE_EVENTS_BTF_ARGS

Posted by Steven Rostedt 2 days, 19 hours ago

From: Steven Rostedt <rostedt@goodmis.org>

The option PROBE_EVENTS_BTF_ARGS enables the functions
btf_find_func_proto() and btf_get_func_param() which are used by the
function argument tracing code. The option FUNCTION_TRACE_ARGS was
dependent on the same configs that PROBE_EVENTS_BTF_ARGS was dependent on,
but it was also dependent on PROBE_EVENTS_BTF_ARGS. In fact, if
PROBE_EVENTS_BTF_ARGS is supported then FUNCTION_TRACE_ARGS is supported.

Just make FUNCTION_TRACE_ARGS depend on PROBE_EVENTS_BTF_ARGS.

Fixes: 533c20b062d7c ("ftrace: Add print_function_args()")
Closes: https://lore.kernel.org/all/DB9PR08MB75820599801BAD118D123D7D93AD2@DB9PR08MB7582.eurprd08.prod.outlook.com/
Reported-by: Christian Loehle <Christian.Loehle@arm.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 kernel/trace/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 033fba0633cf..a3f35c7d83b6 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -265,8 +265,7 @@ config FUNCTION_GRAPH_RETADDR
 
 config FUNCTION_TRACE_ARGS
        bool
-	depends on HAVE_FUNCTION_ARG_ACCESS_API
-	depends on DEBUG_INFO_BTF
+	depends on PROBE_EVENTS_BTF_ARGS
 	default y
 	help
 	  If supported with function argument access API and BTF, then
-- 
2.47.2

Re: [PATCH] ftrace: Have tracing function args depend on PROBE_EVENTS_BTF_ARGS

Posted by Christian Loehle 2 days, 18 hours ago

On 4/1/25 16:36, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
> 
> The option PROBE_EVENTS_BTF_ARGS enables the functions
> btf_find_func_proto() and btf_get_func_param() which are used by the
> function argument tracing code. The option FUNCTION_TRACE_ARGS was
> dependent on the same configs that PROBE_EVENTS_BTF_ARGS was dependent on,
> but it was also dependent on PROBE_EVENTS_BTF_ARGS. In fact, if
> PROBE_EVENTS_BTF_ARGS is supported then FUNCTION_TRACE_ARGS is supported.
> 
> Just make FUNCTION_TRACE_ARGS depend on PROBE_EVENTS_BTF_ARGS.
> 
> Fixes: 533c20b062d7c ("ftrace: Add print_function_args()")
> Closes: https://lore.kernel.org/all/DB9PR08MB75820599801BAD118D123D7D93AD2@DB9PR08MB7582.eurprd08.prod.outlook.com/
> Reported-by: Christian Loehle <Christian.Loehle@arm.com>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

Tested-by: Christian Loehle <Christian.Loehle@arm.com>

> ---
>  kernel/trace/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 033fba0633cf..a3f35c7d83b6 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -265,8 +265,7 @@ config FUNCTION_GRAPH_RETADDR
>  
>  config FUNCTION_TRACE_ARGS
>         bool
> -	depends on HAVE_FUNCTION_ARG_ACCESS_API
> -	depends on DEBUG_INFO_BTF
> +	depends on PROBE_EVENTS_BTF_ARGS
>  	default y
>  	help
>  	  If supported with function argument access API and BTF, then