iio: hid-sensor-prox: fix SCALE and OFFSET calculation

[PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation

Posted by Zhang Lixu 8 months, 3 weeks ago

This patch series addresses issues in the hid-sensor-prox driver related to
SCALE and OFFSET calculations. The changes include restoring lost scale
assignments, supporting multi-channel SCALE calculation, and fixing incorrect
OFFSET calculation.


Zhang Lixu (3):
  iio: hid-sensor-prox: Restore lost scale assignments
  iio: hid-sensor-prox: support multi-channel SCALE calculation
  iio: hid-sensor-prox: Fix incorrect OFFSET calculation

 .../hid-sensors/hid-sensor-attributes.c       |  4 ++++
 drivers/iio/light/hid-sensor-prox.c           | 22 ++++++++++++-------
 2 files changed, 18 insertions(+), 8 deletions(-)


base-commit: e21edb1638e82460f126a6e49bcdd958d452929c
-- 
2.43.0

Re: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation

Posted by Jonathan Cameron 8 months, 3 weeks ago

On Mon, 31 Mar 2025 13:50:19 +0800
Zhang Lixu <lixu.zhang@intel.com> wrote:

> This patch series addresses issues in the hid-sensor-prox driver related to
> SCALE and OFFSET calculations. The changes include restoring lost scale
> assignments, supporting multi-channel SCALE calculation, and fixing incorrect
> OFFSET calculation.
> 
Hi.

Generally I prefer to see review tags (Srinivas' Acks here) given on list
but in I trust Srinivas to have done a thorough review (or to shout when he
sees this!) and the changes look correct to me, applied to the fixes-togreg-testing
branch of iio.git.

Odd point in merge cycle hence the odd temporary branch.

Jonathan

> 
> Zhang Lixu (3):
>   iio: hid-sensor-prox: Restore lost scale assignments
>   iio: hid-sensor-prox: support multi-channel SCALE calculation
>   iio: hid-sensor-prox: Fix incorrect OFFSET calculation
> 
>  .../hid-sensors/hid-sensor-attributes.c       |  4 ++++
>  drivers/iio/light/hid-sensor-prox.c           | 22 ++++++++++++-------
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 
> 
> base-commit: e21edb1638e82460f126a6e49bcdd958d452929c

Re: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation

Posted by srinivas pandruvada 8 months, 3 weeks ago

On Mon, 2025-03-31 at 12:00 +0100, Jonathan Cameron wrote:
> On Mon, 31 Mar 2025 13:50:19 +0800
> Zhang Lixu <lixu.zhang@intel.com> wrote:
> 
> > This patch series addresses issues in the hid-sensor-prox driver
> > related to
> > SCALE and OFFSET calculations. The changes include restoring lost
> > scale
> > assignments, supporting multi-channel SCALE calculation, and fixing
> > incorrect
> > OFFSET calculation.
> > 
> Hi.
> 
> Generally I prefer to see review tags (Srinivas' Acks here) given on
> list
> but in I trust Srinivas to have done a thorough review (or to shout
> when he
> sees this!) and the changes look correct to me, applied to the fixes-
> togreg-testing
> branch of iio.git.
Hi Jonathan,

I have reviewed these patches internally. From next time, I will make
sure that I ACK on the public lists.

Thanks,
Srinivas

> 
> Odd point in merge cycle hence the odd temporary branch.
> 
> Jonathan
> 
> > 
> > Zhang Lixu (3):
> >   iio: hid-sensor-prox: Restore lost scale assignments
> >   iio: hid-sensor-prox: support multi-channel SCALE calculation
> >   iio: hid-sensor-prox: Fix incorrect OFFSET calculation
> > 
> >  .../hid-sensors/hid-sensor-attributes.c       |  4 ++++
> >  drivers/iio/light/hid-sensor-prox.c           | 22 ++++++++++++---
> > ----
> >  2 files changed, 18 insertions(+), 8 deletions(-)
> > 
> > 
> > base-commit: e21edb1638e82460f126a6e49bcdd958d452929c
>

RE: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation

Posted by Zhang, Lixu 8 months, 3 weeks ago

Hi Jonathan and Srinivas,

Noted. Thank you for merging the patches and reviewing the changes.

Thanks,
Lixu

>-----Original Message-----
>From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
>Sent: Monday, March 31, 2025 10:20 PM
>To: Jonathan Cameron <jic23@kernel.org>; Zhang, Lixu <lixu.zhang@intel.com>
>Cc: linux-iio@vger.kernel.org; lars@metafoo.de; jikos@kernel.org;
>peterz@infradead.org; gregkh@linuxfoundation.org; ribalda@chromium.org;
>archana.patni@linux.intel.com; linux-kernel@vger.kernel.org; linux-
>input@vger.kernel.org; Xu, Even <even.xu@intel.com>
>Subject: Re: [PATCH 0/3] iio: hid-sensor-prox: fix SCALE and OFFSET calculation
>
>On Mon, 2025-03-31 at 12:00 +0100, Jonathan Cameron wrote:
>> On Mon, 31 Mar 2025 13:50:19 +0800
>> Zhang Lixu <lixu.zhang@intel.com> wrote:
>>
>> > This patch series addresses issues in the hid-sensor-prox driver
>> > related to SCALE and OFFSET calculations. The changes include
>> > restoring lost scale assignments, supporting multi-channel SCALE
>> > calculation, and fixing incorrect OFFSET calculation.
>> >
>> Hi.
>>
>> Generally I prefer to see review tags (Srinivas' Acks here) given on
>> list but in I trust Srinivas to have done a thorough review (or to
>> shout when he sees this!) and the changes look correct to me, applied
>> to the fixes- togreg-testing branch of iio.git.
>Hi Jonathan,
>
>I have reviewed these patches internally. From next time, I will make sure that I
>ACK on the public lists.
>
>Thanks,
>Srinivas
>
>>
>> Odd point in merge cycle hence the odd temporary branch.
>>
>> Jonathan
>>
>> >
>> > Zhang Lixu (3):
>> >   iio: hid-sensor-prox: Restore lost scale assignments
>> >   iio: hid-sensor-prox: support multi-channel SCALE calculation
>> >   iio: hid-sensor-prox: Fix incorrect OFFSET calculation
>> >
>> >  .../hid-sensors/hid-sensor-attributes.c       |  4 ++++
>> >  drivers/iio/light/hid-sensor-prox.c           | 22 ++++++++++++---
>> > ----
>> >  2 files changed, 18 insertions(+), 8 deletions(-)
>> >
>> >
>> > base-commit: e21edb1638e82460f126a6e49bcdd958d452929c
>>