Adds module description to the backtrace suppression test

Fixes:  ("19f3496") kunit: add test cases for backtrace warning suppression

Signed-off-by: Alessandro Carminati <acarmina@redhat.com>
---
 lib/kunit/backtrace-suppression-test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/kunit/backtrace-suppression-test.c b/lib/kunit/backtrace-suppression-test.c
index 8b4125af2481..d4c5df09bba6 100644
--- a/lib/kunit/backtrace-suppression-test.c
+++ b/lib/kunit/backtrace-suppression-test.c
@@ -102,3 +102,4 @@ static struct kunit_suite backtrace_suppression_test_suite = {
 kunit_test_suites(&backtrace_suppression_test_suite);
 
 MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("KUnit test to verify warning backtrace suppression");
-- 
2.34.1

On Sat, 29 Mar 2025 at 23:06, Alessandro Carminati <acarmina@redhat.com> wrote:
>
> Adds module description to the backtrace suppression test
>
> Fixes:  ("19f3496") kunit: add test cases for backtrace warning suppression
>
> Signed-off-by: Alessandro Carminati <acarmina@redhat.com>
> ---

The "Fixes" tag here should be immediately before the Signed-off-by
line, without a newline. Also, ideally the format should be something
like:
Fixes: d03d078df162 ("kunit: add test cases for backtrace warning suppression")

(But you'll need to make sure the commit hash matches the one which
actually lands -- I picked d03d078df162 from the current
mm-nonmm-unstable branch.)

Nevertheless, I like the content of this, so it should be either
accepted or rolled into a new version of the backtrace suppression
test.

Acked-by: David Gow <davidgow@google.com>

Cheers,
-- David

>  lib/kunit/backtrace-suppression-test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/kunit/backtrace-suppression-test.c b/lib/kunit/backtrace-suppression-test.c
> index 8b4125af2481..d4c5df09bba6 100644
> --- a/lib/kunit/backtrace-suppression-test.c
> +++ b/lib/kunit/backtrace-suppression-test.c
> @@ -102,3 +102,4 @@ static struct kunit_suite backtrace_suppression_test_suite = {
>  kunit_test_suites(&backtrace_suppression_test_suite);
>
>  MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("KUnit test to verify warning backtrace suppression");
> --
> 2.34.1
>

On Sun, Mar 30, 2025 at 01:11:59PM +0800, David Gow wrote:
> On Sat, 29 Mar 2025 at 23:06, Alessandro Carminati <acarmina@redhat.com> wrote:
> >
> > Adds module description to the backtrace suppression test
> >
> > Fixes:  ("19f3496") kunit: add test cases for backtrace warning suppression
> >
> > Signed-off-by: Alessandro Carminati <acarmina@redhat.com>
> > ---
> 
> The "Fixes" tag here should be immediately before the Signed-off-by
> line, without a newline. Also, ideally the format should be something
> like:
> Fixes: d03d078df162 ("kunit: add test cases for backtrace warning suppression")
> 

Yeah.  Everyone should configure the default hash length to 12.

git config set --global core.abbrev 12

I generate my fixes tags like so:

#!/bin/bash

git log -1 --format='Fixes: %h ("%s")' $*

regards,
dan carpenter