[PATCH v7 00/12] platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements

Kurt Borja posted 12 patches 8 months, 3 weeks ago
Documentation/ABI/testing/debugfs-alienware-wmi    |   44 +
.../ABI/testing/sysfs-platform-alienware-wmi       |   14 +
.../admin-guide/laptops/alienware-wmi.rst          |  127 +++
Documentation/admin-guide/laptops/index.rst        |    1 +
Documentation/wmi/devices/alienware-wmi.rst        |  383 +++-----
MAINTAINERS                                        |    3 +
drivers/platform/x86/dell/Kconfig                  |    1 +
drivers/platform/x86/dell/alienware-wmi-wmax.c     | 1034 +++++++++++++++++---
8 files changed, 1195 insertions(+), 412 deletions(-)
[PATCH v7 00/12] platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements
Posted by Kurt Borja 8 months, 3 weeks ago
Hi all,

This set mainly adds hwmon and manual fan control support (patches 7-8)
to the alienware-wmi driver, after some improvements.

Thank you for your feedback :)

---
Changes in v7:

[01/12]
  - Mention WMAX_OPERATION_* -> AWCC_OP_* in commit message

[02/12]
  - Reorder the thermal defines as Ilpo suggested
  - Use FIELD_GET in awcc_platform_profile_get in this patch instead of
    [03/12]
  - Reword commit message, including title, to be more coherent with the
    changes

[03/12]
  - Drop inline attributes
  - drop __ prefix from awcc_wmi_command()
  - Add @ to kernel-doc variable reference

[05/12]
  - Reword commit message to better describe changes

[08/12]
  - Fix typo: aproximate -> approximate

[09/12]
  - Replace ARRAY_SIZE() with sizeof() when naming the debugfs directory

[11/12]
  - Fix typo: repurpused -> repurposed
  - Drop uses of "We"

Link to v6: https://lore.kernel.org/r/20250313-hwm-v6-0-17b57f787d77@gmail.com

---
Kurt Borja (12):
      platform/x86: alienware-wmi-wmax: Rename thermal related symbols
      platform/x86: alienware-wmi-wmax: Improve ID processing
      platform/x86: alienware-wmi-wmax: Improve internal AWCC API
      platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
      platform/x86: alienware-wmi-wmax: Improve platform profile probe
      platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
      platform/x86: alienware-wmi-wmax: Add HWMON support
      platform/x86: alienware-wmi-wmax: Add support for manual fan control
      platform/x86: alienware-wmi-wmax: Add a DebugFS interface
      Documentation: wmi: Improve and update alienware-wmi documentation
      Documentation: admin-guide: laptops: Add documentation for alienware-wmi
      Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi

 Documentation/ABI/testing/debugfs-alienware-wmi    |   44 +
 .../ABI/testing/sysfs-platform-alienware-wmi       |   14 +
 .../admin-guide/laptops/alienware-wmi.rst          |  127 +++
 Documentation/admin-guide/laptops/index.rst        |    1 +
 Documentation/wmi/devices/alienware-wmi.rst        |  383 +++-----
 MAINTAINERS                                        |    3 +
 drivers/platform/x86/dell/Kconfig                  |    1 +
 drivers/platform/x86/dell/alienware-wmi-wmax.c     | 1034 +++++++++++++++++---
 8 files changed, 1195 insertions(+), 412 deletions(-)
---
base-commit: 1a9239bb4253f9076b5b4b2a1a4e8d7defd77a95
change-id: 20250305-hwm-f7bd91902b57

Best regards,
-- 
 ~ Kurt
Re: [PATCH v7 00/12] platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements
Posted by Ilpo Järvinen 8 months, 1 week ago
On Sat, 29 Mar 2025 04:32:17 -0300, Kurt Borja wrote:

> This set mainly adds hwmon and manual fan control support (patches 7-8)
> to the alienware-wmi driver, after some improvements.
> 
> Thank you for your feedback :)
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[01/12] platform/x86: alienware-wmi-wmax: Rename thermal related symbols
        commit: 8a1a0fb55f8a8e482314d2769a9cac0703016fd4
[02/12] platform/x86: alienware-wmi-wmax: Improve ID processing
        commit: a000da9dbc249642233587a80df03130e8983d10
[03/12] platform/x86: alienware-wmi-wmax: Improve internal AWCC API
        commit: 45983d19f305a562386f4d13accd11056b99f48a
[04/12] platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
        commit: 77bb2ec55700ee3af0cd902398fa903363826679
[05/12] platform/x86: alienware-wmi-wmax: Improve platform profile probe
        commit: 32b6372ddd4385a47a6a4b6ccff0c22b7be8765a
[06/12] platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
        commit: 3dde0ae1eb5f00c1d61959d1fcce2b1b46ccc199
[07/12] platform/x86: alienware-wmi-wmax: Add HWMON support
        commit: d699907834959c87a6b6c5214d5e9a3e8ba6b5a1
[08/12] platform/x86: alienware-wmi-wmax: Add support for manual fan control
        commit: 07ac275981b1f11a58dd7bb7790eed66252b072c
[09/12] platform/x86: alienware-wmi-wmax: Add a DebugFS interface
        commit: b028fb497c152febbdc48b544aaaadbe06406dbf
[10/12] Documentation: wmi: Improve and update alienware-wmi documentation
        commit: a56d188a0a8f3df4860acf66a6af89318ce611be
[11/12] Documentation: admin-guide: laptops: Add documentation for alienware-wmi
        commit: 3e48767ab53b56d31c77a063d022ca9aca43bf22
[12/12] Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi
        commit: 361813db5d9ba33434754c0de1207a2b91264ab1

--
 i.
Re: [PATCH v7 00/12] platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements
Posted by Kurt Borja 8 months, 1 week ago
On Fri Apr 11, 2025 at 9:23 AM -03, Ilpo Järvinen wrote:
> On Sat, 29 Mar 2025 04:32:17 -0300, Kurt Borja wrote:
>
>> This set mainly adds hwmon and manual fan control support (patches 7-8)
>> to the alienware-wmi driver, after some improvements.
>> 
>> Thank you for your feedback :)
>> 
>
>
> Thank you for your contribution, it has been applied to my local
> review-ilpo-next branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo-next branch only once I've pushed my
> local branch there, which might take a while.
>
> The list of commits applied:
> [01/12] platform/x86: alienware-wmi-wmax: Rename thermal related symbols
>         commit: 8a1a0fb55f8a8e482314d2769a9cac0703016fd4
> [02/12] platform/x86: alienware-wmi-wmax: Improve ID processing
>         commit: a000da9dbc249642233587a80df03130e8983d10
> [03/12] platform/x86: alienware-wmi-wmax: Improve internal AWCC API
>         commit: 45983d19f305a562386f4d13accd11056b99f48a
> [04/12] platform/x86: alienware-wmi-wmax: Modify supported_thermal_profiles[]
>         commit: 77bb2ec55700ee3af0cd902398fa903363826679
> [05/12] platform/x86: alienware-wmi-wmax: Improve platform profile probe
>         commit: 32b6372ddd4385a47a6a4b6ccff0c22b7be8765a
> [06/12] platform/x86: alienware-wmi-wmax: Add support for the "custom" thermal profile
>         commit: 3dde0ae1eb5f00c1d61959d1fcce2b1b46ccc199
> [07/12] platform/x86: alienware-wmi-wmax: Add HWMON support
>         commit: d699907834959c87a6b6c5214d5e9a3e8ba6b5a1
> [08/12] platform/x86: alienware-wmi-wmax: Add support for manual fan control
>         commit: 07ac275981b1f11a58dd7bb7790eed66252b072c
> [09/12] platform/x86: alienware-wmi-wmax: Add a DebugFS interface
>         commit: b028fb497c152febbdc48b544aaaadbe06406dbf
> [10/12] Documentation: wmi: Improve and update alienware-wmi documentation
>         commit: a56d188a0a8f3df4860acf66a6af89318ce611be
> [11/12] Documentation: admin-guide: laptops: Add documentation for alienware-wmi
>         commit: 3e48767ab53b56d31c77a063d022ca9aca43bf22
> [12/12] Documentation: ABI: Add sysfs platform and debugfs ABI documentation for alienware-wmi
>         commit: 361813db5d9ba33434754c0de1207a2b91264ab1
>
> --
>  i.

Thanks a lot for your work on this, Armin and Ilpo!

:)

-- 
 ~ Kurt