From: Arnd Bergmann <arnd@arndb.de>

The newly added driver fails to link without this:

ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id" [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!

Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire BPT DMA")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/sof/intel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
index 41cb33fe98fb..7e92aa2f7e39 100644
--- a/sound/soc/sof/intel/Kconfig
+++ b/sound/soc/sof/intel/Kconfig
@@ -351,6 +351,7 @@ endif ## SND_SOC_SOF_HDA_GENERIC
 
 config SND_SOF_SOF_HDA_SDW_BPT
 	tristate
+	select SND_HDA_EXT_CORE
 	help
 	  This option is not user-selectable but automagically handled by
 	  'select' statements at a higher level.
-- 
2.39.5

> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Friday, March 28, 2025 9:25 PM
> To: Liam Girdwood <lgirdwood@gmail.com>; Peter Ujfalusi
> <peter.ujfalusi@linux.intel.com>; Bard Liao <yung-chuan.liao@linux.intel.com>;
> Ranjani Sridharan <ranjani.sridharan@linux.intel.com>; Daniel Baluta
> <daniel.baluta@nxp.com>; Mark Brown <broonie@kernel.org>; Jaroslav Kysela
> <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Vinod Koul
> <vkoul@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; Kai Vehmanen
> <kai.vehmanen@linux.intel.com>; Pierre-Louis Bossart <pierre-
> louis.bossart@linux.dev>; sound-open-firmware@alsa-project.org; linux-
> sound@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
> CONFIG_SND_SOF_SOF_HDA_SDW_BPT
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The newly added driver fails to link without this:
> 
> ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id"
> [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-
> intel-hda-sdw-bpt.ko] undefined!
> ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id"
> [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> 
> Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire
> BPT DMA")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I have the same patch which is pending review/apply.
https://patchwork.kernel.org/project/alsa-devel/patch/20250321023032.7420-2-yung-chuan.liao@linux.intel.com/
I am fine if we go with this patch.
Acked-by: Bard Liao <yung-chuan.liao@linux.intel.com>


> ---
>  sound/soc/sof/intel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index 41cb33fe98fb..7e92aa2f7e39 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -351,6 +351,7 @@ endif ## SND_SOC_SOF_HDA_GENERIC
> 
>  config SND_SOF_SOF_HDA_SDW_BPT
>  	tristate
> +	select SND_HDA_EXT_CORE
>  	help
>  	  This option is not user-selectable but automagically handled by
>  	  'select' statements at a higher level.
> --
> 2.39.5

On 28-03-25, 14:15, Liao, Bard wrote:
> 
> 
> > -----Original Message-----
> > From: Arnd Bergmann <arnd@kernel.org>
> > Sent: Friday, March 28, 2025 9:25 PM
> > To: Liam Girdwood <lgirdwood@gmail.com>; Peter Ujfalusi
> > <peter.ujfalusi@linux.intel.com>; Bard Liao <yung-chuan.liao@linux.intel.com>;
> > Ranjani Sridharan <ranjani.sridharan@linux.intel.com>; Daniel Baluta
> > <daniel.baluta@nxp.com>; Mark Brown <broonie@kernel.org>; Jaroslav Kysela
> > <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; Vinod Koul
> > <vkoul@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>; Kai Vehmanen
> > <kai.vehmanen@linux.intel.com>; Pierre-Louis Bossart <pierre-
> > louis.bossart@linux.dev>; sound-open-firmware@alsa-project.org; linux-
> > sound@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: select
> > CONFIG_SND_SOF_SOF_HDA_SDW_BPT
> > 
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > The newly added driver fails to link without this:
> > 
> > ERROR: modpost: "snd_hdac_ext_stream_start" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_clear" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_setup" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_set_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_stream_reset" [sound/soc/sof/intel/snd-sof-
> > intel-hda-sdw-bpt.ko] undefined!
> > ERROR: modpost: "snd_hdac_ext_bus_link_clear_stream_id"
> > [sound/soc/sof/intel/snd-sof-intel-hda-sdw-bpt.ko] undefined!
> > 
> > Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire
> > BPT DMA")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> I have the same patch which is pending review/apply.
> https://patchwork.kernel.org/project/alsa-devel/patch/20250321023032.7420-2-yung-chuan.liao@linux.intel.com/
> I am fine if we go with this patch.
> Acked-by: Bard Liao <yung-chuan.liao@linux.intel.com>

I have picked yours as that came first, thanks

-- 
~Vinod