drm/bridge: thc63lvd1024: Use dev_err_probe()

[PATCH v2] drm/bridge: thc63lvd1024: Use dev_err_probe()

Posted by shao.mingyin@zte.com.cn 8 months, 3 weeks ago

From: Zhang Enpei <zhang.enpei@zte.com.cn>

Replace the open-code with dev_err_probe() to simplify the code.

Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
---
v2:
	- reduce a PTR_ERR call since dev_err_probe() will add
	  the error value to the message
 drivers/gpu/drm/bridge/thc63lvd1024.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c
index bba10cf9b4f9..8f3096fa3dd7 100644
--- a/drivers/gpu/drm/bridge/thc63lvd1024.c
+++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
@@ -188,14 +188,9 @@ static int thc63_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, thc63);

 	thc63->vcc = devm_regulator_get(thc63->dev, "vcc");
-	if (IS_ERR(thc63->vcc)) {
-		if (PTR_ERR(thc63->vcc) == -EPROBE_DEFER)
-			return -EPROBE_DEFER;
-
-		dev_err(thc63->dev, "Unable to get \"vcc\" supply: %ld\n",
-			PTR_ERR(thc63->vcc));
-		return PTR_ERR(thc63->vcc);
-	}
+	if (IS_ERR(thc63->vcc))
+		return dev_err_probe(thc63->dev, PTR_ERR(thc63->vcc),
+				     "Unable to get \"vcc\" supply\n");

 	ret = thc63_gpio_init(thc63);
 	if (ret)
-- 
2.25.1

Re: [PATCH v2] drm/bridge: thc63lvd1024: Use dev_err_probe()

Posted by Laurent Pinchart 8 months, 3 weeks ago

Hi Zhang and Shao,

On Thu, Mar 27, 2025 at 11:52:49AM +0800, shao.mingyin@zte.com.cn wrote:
> From: Zhang Enpei <zhang.enpei@zte.com.cn>
> 
> Replace the open-code with dev_err_probe() to simplify the code.
> 
> Signed-off-by: Zhang Enpei <zhang.enpei@zte.com.cn>
> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
> v2:
> 	- reduce a PTR_ERR call since dev_err_probe() will add
> 	  the error value to the message
>  drivers/gpu/drm/bridge/thc63lvd1024.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c
> index bba10cf9b4f9..8f3096fa3dd7 100644
> --- a/drivers/gpu/drm/bridge/thc63lvd1024.c
> +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c
> @@ -188,14 +188,9 @@ static int thc63_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, thc63);
> 
>  	thc63->vcc = devm_regulator_get(thc63->dev, "vcc");
> -	if (IS_ERR(thc63->vcc)) {
> -		if (PTR_ERR(thc63->vcc) == -EPROBE_DEFER)
> -			return -EPROBE_DEFER;
> -
> -		dev_err(thc63->dev, "Unable to get \"vcc\" supply: %ld\n",
> -			PTR_ERR(thc63->vcc));
> -		return PTR_ERR(thc63->vcc);
> -	}
> +	if (IS_ERR(thc63->vcc))
> +		return dev_err_probe(thc63->dev, PTR_ERR(thc63->vcc),
> +				     "Unable to get \"vcc\" supply\n");
> 
>  	ret = thc63_gpio_init(thc63);
>  	if (ret)

-- 
Regards,

Laurent Pinchart