[RESEND v5 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC

Zhang Yi posted 2 patches 8 months, 3 weeks ago
There is a newer version of this series
[RESEND v5 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
Posted by Zhang Yi 8 months, 3 weeks ago
Add device tree binding documentation for Everest ES8389 which
is different from ES8388

Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>
---
 .../bindings/sound/everest,es8389.yaml        | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/everest,es8389.yaml

diff --git a/Documentation/devicetree/bindings/sound/everest,es8389.yaml b/Documentation/devicetree/bindings/sound/everest,es8389.yaml
new file mode 100644
index 000000000000..a673df485ab3
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/everest,es8389.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/everest,es8389.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Everest ES8389 audio CODEC
+
+maintainers:
+  - Michael Zhang <zhangyi@everest-semi.com>
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: everest,es8389
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: clock for master clock (MCLK)
+
+  clock-names:
+    items:
+      - const: mclk
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - "#sound-dai-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      es8389: codec@10 {
+        compatible = "everest,es8389";
+        reg = <0x10>;
+        #sound-dai-cells = <0>;
+      };
+    };
-- 
2.17.1
Re: [RESEND v5 2/2] ASoC: dt-bindings: Add Everest ES8389 audio CODEC
Posted by Krzysztof Kozlowski 8 months, 3 weeks ago
On 27/03/2025 07:35, Zhang Yi wrote:
> Add device tree binding documentation for Everest ES8389 which
> is different from ES8388
> 
> Signed-off-by: Zhang Yi <zhangyi@everest-semi.com>

So you not only ignored review but I gave you long instruction what to
do, so that will not happen. And what happened? You wrote:

"Thank you for the explanation.I will do it in a following patch"

and then ignored it entirely!

That entire instruction was on purpose - to prevent possible mistake, to
explain how the process works, because I assume you will not read our
documents like submitting-patches. Well, you should read them prior to
sending, but it happens, so thus my instruction.

And yet we are in the same spot.

I am not doing the same work twice.

Best regards,
Krzysztof