[v3] Trusted Execution Environment (TEE) driver for Qualcomm TEE (QTEE)

[PATCH v3 01/11] tee: allow a driver to allocate a tee_device without a pool

Posted by Amirreza Zarrabi 8 months, 3 weeks ago

A TEE driver doesn't always need to provide a pool if it doesn't
support memory sharing ioctls and can allocate memory for TEE
messages in another way. Although this is mentioned in the
documentation for tee_device_alloc(), it is not handled correctly.

Signed-off-by: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>
---
 drivers/tee/tee_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
index d113679b1e2d..24edce4cdbaa 100644
--- a/drivers/tee/tee_core.c
+++ b/drivers/tee/tee_core.c
@@ -888,7 +888,7 @@ struct tee_device *tee_device_alloc(const struct tee_desc *teedesc,
 
 	if (!teedesc || !teedesc->name || !teedesc->ops ||
 	    !teedesc->ops->get_version || !teedesc->ops->open ||
-	    !teedesc->ops->release || !pool)
+	    !teedesc->ops->release)
 		return ERR_PTR(-EINVAL);
 
 	teedev = kzalloc(sizeof(*teedev), GFP_KERNEL);

-- 
2.34.1

Re: [PATCH v3 01/11] tee: allow a driver to allocate a tee_device without a pool

Posted by Sumit Garg 7 months, 4 weeks ago

On Thu, Mar 27, 2025 at 07:47:23PM -0700, Amirreza Zarrabi wrote:
> A TEE driver doesn't always need to provide a pool if it doesn't
> support memory sharing ioctls and can allocate memory for TEE
> messages in another way. Although this is mentioned in the
> documentation for tee_device_alloc(), it is not handled correctly.
> 
> Signed-off-by: Amirreza Zarrabi <amirreza.zarrabi@oss.qualcomm.com>
> ---
>  drivers/tee/tee_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> diff --git a/drivers/tee/tee_core.c b/drivers/tee/tee_core.c
> index d113679b1e2d..24edce4cdbaa 100644
> --- a/drivers/tee/tee_core.c
> +++ b/drivers/tee/tee_core.c
> @@ -888,7 +888,7 @@ struct tee_device *tee_device_alloc(const struct tee_desc *teedesc,
>  
>  	if (!teedesc || !teedesc->name || !teedesc->ops ||
>  	    !teedesc->ops->get_version || !teedesc->ops->open ||
> -	    !teedesc->ops->release || !pool)
> +	    !teedesc->ops->release)
>  		return ERR_PTR(-EINVAL);
>  
>  	teedev = kzalloc(sizeof(*teedev), GFP_KERNEL);
> 
> -- 
> 2.34.1
> 
>