[PATCH v2 3/4] drm/panel: deprecate old-style panel allocation

Anusha Srivatsa posted 4 patches 8 months, 3 weeks ago
There is a newer version of this series
[PATCH v2 3/4] drm/panel: deprecate old-style panel allocation
Posted by Anusha Srivatsa 8 months, 3 weeks ago
Start moving to the new refcounted allocations using
the new API devm_drm_panel_alloc(). Deprecate any other
allocation.

v2: make the documentation changes in v1 more precise (Maxime)

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
---
 drivers/gpu/drm/drm_panel.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index 7b17531d85a4dc3031709919564d2e4d8332f748..870bf8d471ee9c5fe65d88acc13661cacd883b9b 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -74,8 +74,9 @@ EXPORT_SYMBOL(drm_panel_init);
  * drm_panel_add - add a panel to the global registry
  * @panel: panel to add
  *
- * Add a panel to the global registry so that it can be looked up by display
- * drivers.
+ * Add a panel to the global registry so that it can be looked
+ * up by display drivers. The panel to be added must have been
+ * allocated by devm_drm_panel_alloc().
  */
 void drm_panel_add(struct drm_panel *panel)
 {

-- 
2.48.1
Re: [PATCH v2 3/4] drm/panel: deprecate old-style panel allocation
Posted by Luca Ceresoli 8 months, 3 weeks ago
On Thu, 27 Mar 2025 10:55:41 -0400
Anusha Srivatsa <asrivats@redhat.com> wrote:

> Start moving to the new refcounted allocations using
> the new API devm_drm_panel_alloc(). Deprecate any other
> allocation.
> 
> v2: make the documentation changes in v1 more precise (Maxime)

Note that the changelog (list of changes since previous versions)
should be...

> 
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
> ---

...here, just after the '---' line. In such way it will not be applied
by 'git am' and similar tools and will not appear in the final commit
when your patch is applied. The patch history is not needed in the
final commit.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [PATCH v2 3/4] drm/panel: deprecate old-style panel allocation
Posted by Maxime Ripard 8 months, 3 weeks ago
On Thu, 27 Mar 2025 10:55:41 -0400, Anusha Srivatsa wrote:
> Start moving to the new refcounted allocations using
> the new API devm_drm_panel_alloc(). Deprecate any other
> allocation.
> 
> v2: make the documentation changes in v1 more precise (Maxime)
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@kernel.org>

Thanks!
Maxime