[PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards

Lukasz Majewski posted 1 patch 8 months, 3 weeks ago
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)
[PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards
Posted by Lukasz Majewski 8 months, 3 weeks ago
The measurement device on Liebherr's (LWE) boards is used to monitor
the overall state of the device. It does have SPI interface to
communicate with Linux host via spidev driver. Document the SPI DT
binding as trivial SPI device.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
Changes for v2:
- Use already in-kernel available 'lwn' vendor prefix instead of introducing
  a new one
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 8da408107e55..1e37144e7017 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -161,6 +161,8 @@ properties:
           - jedec,spd5118
             # Linear Technology LTC2488
           - lineartechnology,ltc2488
+            # Liebherr on-board measurement SPI device
+          - lwn,btt
             # 5 Bit Programmable, Pulse-Width Modulator
           - maxim,ds1050
             # 10 kOhm digital potentiometer with I2C interface
-- 
2.39.5
Re: [PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards
Posted by Conor Dooley 8 months, 3 weeks ago
On Wed, Mar 26, 2025 at 06:18:38PM +0100, Lukasz Majewski wrote:
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

See comments on v1 and v1's resend. Should continue the conversation on
the latter, rather than splitting it here. Please also do not send
another version, where this is bundled with the spidev driver patch,
until that conversation has been resolved.

Cheers,
Conor.

> ---
> Changes for v2:
> - Use already in-kernel available 'lwn' vendor prefix instead of introducing
>   a new one
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 8da408107e55..1e37144e7017 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -161,6 +161,8 @@ properties:
>            - jedec,spd5118
>              # Linear Technology LTC2488
>            - lineartechnology,ltc2488
> +            # Liebherr on-board measurement SPI device
> +          - lwn,btt
>              # 5 Bit Programmable, Pulse-Width Modulator
>            - maxim,ds1050
>              # 10 kOhm digital potentiometer with I2C interface
> -- 
> 2.39.5
> 
Re: [PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards
Posted by Fabio Estevam 8 months, 3 weeks ago
Hi  Lukasz,

On Wed, Mar 26, 2025 at 2:19 PM Lukasz Majewski <lukma@denx.de> wrote:
>
> The measurement device on Liebherr's (LWE) boards is used to monitor
> the overall state of the device. It does have SPI interface to
> communicate with Linux host via spidev driver. Document the SPI DT
> binding as trivial SPI device.

Can't you use lwn,bk4-spi instead?

Please check:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml?h=v6.14
Re: [PATCH v2] dt-bindings: trivial-devices: Document SPI measurement on LWE boards
Posted by Lukasz Majewski 8 months, 3 weeks ago
Hi Fabio,

> Hi  Lukasz,
> 
> On Wed, Mar 26, 2025 at 2:19 PM Lukasz Majewski <lukma@denx.de> wrote:
> >
> > The measurement device on Liebherr's (LWE) boards is used to monitor
> > the overall state of the device. It does have SPI interface to
> > communicate with Linux host via spidev driver. Document the SPI DT
> > binding as trivial SPI device.  
> 
> Can't you use lwn,bk4-spi instead?

Conceptually, those are two different devices.

> 
> Please check:
> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/misc/lwn,bk4-spi.yaml?h=v6.14




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de